search

TheAxonLab / hcph-sops

SOPs of the HCPh project
https://www.axonlab.org/hcph-sops/
Creative Commons Attribution 4.0 International
0 stars 6 forks source link

[EDF to BIDS conversion] clean up obsolete commented lines of `eyetrackingrun.py` and make sure code snippets in `edf_to_bids.md` match `eyetrackingrun.py` #458

Open celprov opened 8 months ago

celprov commented 8 months ago

It seems originally the code wanted to support both eyes (that's the snippets that are referenced to in edf_to_bids.md), but the developers retracted (code implemented in eyetrackingrun.py). The changes were however not reflected in the notebook.

The code in eyetrackingrun.py moreover reflects changes in the BEP20, but those changes are not reflected in the code snippets in edf_to_bids.md.

Here are the concerned lines:

https://github.com/TheAxonLab/hcph-sops/blob/c370b0461b197c78716e33b602214c31e6a5acc3/code/eyetracking/eyetrackingrun.py#L309-L319

https://github.com/TheAxonLab/hcph-sops/blob/c370b0461b197c78716e33b602214c31e6a5acc3/code/eyetracking/eyetrackingrun.py#L367-L395

https://github.com/TheAxonLab/hcph-sops/blob/c370b0461b197c78716e33b602214c31e6a5acc3/code/eyetracking/eyetrackingrun.py#L453-L456

https://github.com/TheAxonLab/hcph-sops/blob/c370b0461b197c78716e33b602214c31e6a5acc3/code/eyetracking/eyetrackingrun.py#L598-L599