search

TheBB / aligulac

Source code for the Aligulac project: a statistical tool for the analysis of the SC2 pro and semipro scene.
http://aligulac.com
250 stars 31 forks source link

Prediction: Internal server error (500) when updating without numeric score input #314

Open chill0r opened 3 years ago

chill0r commented 3 years ago

Description: When updating a match prediction progress with no number input (non numeric or empty) in either of the participant fields a 500 Internal Server Error will be returned

What should happen Invalid fields should be interpreted as "0"

What is happening 500 Internal server error

How to reproduce

  1. Generate (any) prediction
  2. Insert a non numeric value (or empty) in the Update match progress scores
  3. Press "Update match progress"
chill0r commented 3 years ago

Possibly a check for a numeric value in https://github.com/TheBB/aligulac/blob/fe3ffedf0cbb0fc864dc84a3908808400b414548/aligulac/simul/formats/match.py#L66 could fix this (not tested)