Closed deb0ch closed 7 years ago
Oh, btw I put 2.0.2
as the first version where the alias is made obsolete in anticipation, because I figured that after merging PRs you might want to bump the version number.
But maybe you might want to bump the version number differently ?
That alias was defined for backwards compatibility reasons. Thanks for all your work lately. I hope I can get around to reviews soon.
Would you like to have write access? I think that might be a good way to proceed.
I'm honored that you would trust me with write access and would gladly accept to help you maintaining Spaceline 👍:sparkles:
In my perception, getting write access == becoming a maintainer (I don't see the difference in this case), amarite ?
How would that be going ?
Like how do we organize this: what should I push, not push, what am I and what are you responsible for, when should I wait for your review, how do we share the maintaining work ?
No problem, you clearly understand the minutiae well enough.
Yes, pretty much a maintainer. As a rule of thumb in most of my repos I want all PRs to be checked by a maintainer (one of us) who is also not the author of the PR. So I'll check yours, you'll check mine and for others, whoever of us gets to it first can do it. For trivial changes feel free to push directly. I think this one counts as trivial.
Haha, merged first PR 👍 ✨
I find the mere existence of this alias confusing: why would we need two names for one function ?
Before seeing this
defalias
, I was sure thatspaceline-install
andspaceline-compile
were two distinct functions doing (even slightly) different things, and couldn't believe my eyes when I saw that in fact, no.What was your initial reason for defining this alias ?