search

TheBB / spaceline

Powerline theme from Spacemacs
GNU General Public License v3.0
534 stars 60 forks source link

Actually evaluate :face properties if appropriate #201

Closed jyp closed 5 years ago

jyp commented 5 years ago

Fixes #153

jyp commented 5 years ago

@thblt Ping, what about my later formulation?

thblt commented 5 years ago

@jyp Sorry I forgot to answer (a bit too deep in real-life work these days...). Your last formulation is extremely clear (I didn't understand before that only these 3 symbols got a special handling)

jyp commented 5 years ago

@thblt I have updated the documentation as we had agreed. Is this ok for merging?

thblt commented 5 years ago

@jyp Looks perfect to me, thanks!

jyp commented 5 years ago

@TheBB What about merging this?

TheBB commented 5 years ago

Yeah, in general I'm fine with it.

The original motivation for treating those three four symbols specially was to allow the user to just do :face default-face (which is actually a variable whose value is a face) or :face some-actual-face in the same manner, not needing to quote any of them.

With this PR, as is indicated in the doc changes, one would need to quote the second but not the first. That's fine, I think my original approach was a mistake and it's not good to have too complicated rules about what is evaluated and what isn't.

In summary, face is always then evaluated at runtime. Observe that if face is a list, (,@face) is the same thing as face (just imagine the backquote in there). So actually the two branches of this if evaluate to the same thing. I think then that we might as well drop it entirely.

TheBB commented 5 years ago

Thanks for the patch and sorry for the long wait.