Open Link Settings - Githubissues

TheBLVD / mammoth

GNU Affero General Public License v3.0

187 stars 14 forks source link

Open Link Settings #600

Closed kernjackson closed 4 months ago

kernjackson commented 4 months ago

Overview

Adds Reader View and 3rd party browser support.

[x] Add setting to open links in Reader View #581
[x] Add setting to open links in 3rd party browsers #598

OpenLinker is adapted from the Proton Mail for iOS, which is covered under the GPL-3.0 license.

Settings View Users can quickly toggle Reader View on or off in settings.

Browser Selection Users can select a default 3rd party browser to open links with.

Testing

I was able to test this in the simulator with the following

[x] Safari
[x] Mammoth
[x] Reader View
[ ] Brave
[ ] Chrome
[x] DuckDuckGo
[ ] Edge
[ ] Firefox
[ ] Firefox Focus
[ ] Opera Mini
[ ] Opera Touch

CLAassistant commented 4 months ago

All committers have signed the CLA.

bnolens commented 4 months ago

Very cool! You probably want to add Safari in the list too?

bnolens commented 4 months ago

Very cool! You probably want to add Safari in the list too?

Oh, nvm. Just seeing "System default" is safari.

rileyhCode commented 4 months ago

The user can change their default browser from Safari to something else. If they do that, is there a way for them to specify Safari here?

rileyhCode commented 4 months ago

One additional note: would need to add Proton Mail to the list of licenses/attributions in About.

kernjackson commented 4 months ago

Good point @rileyhCode, I will add that.

derspyy commented 4 months ago

@kernjackson do you think you get sign your commits? i'm pretty sure you can sign them retroactively but feel free to make a new PR.

(p.s. the change i made to localizable is just in order to fix some conflicts, don't mind that, but also you don't need to include that file again because i'll add all new strings later)