TheBastionBot / Bastion

🚀 Get an enhanced Discord experience!
https://bastion.traction.one
GNU General Public License v3.0
311 stars 245 forks source link

[BUG]: Credited/Debited are reversed #619

Closed NuuuubSaibot closed 5 years ago

NuuuubSaibot commented 5 years ago

Describe the bug

To Reproduce Steps to reproduce the behavior:

  1. Read the commands files (give, takeaway, daily, etc.)
bastion[bot] commented 5 years ago

Thank you for opening this issue. A maintainer will get by as soon as possible to address this issue. Since this is your first issue in this repository, please make sure follow the issue template and provide as much detail as possible.

If this is a support question and not really an issue or suggestion, then please ask it in our Discord Server instead. You'll get redirected there anyway.

Cheers, Bastion

NuuuubSaibot commented 5 years ago

Its says credited where it should say debited and vice versa

iamtraction commented 5 years ago

No, actually they aren't. This is the actual use of those words. You're mistaken because of your experience with banks. Search their meaning in dictionary and you'll know why. Perhaps, read this.

NuuuubSaibot commented 5 years ago

English is my first language and I have worked in a bank for 10 years.

I want to clarify that I noticed this when I installed the bot to run it on my own, perhaps it is specific to that installation? If not, I am sorry but it says my account has been debited when i am given something and credited when something is taken. I went in and updated it for my server, but thanks for the extremely rude response man! Best of luck! On May 14, 2019, 8:56 AM -0500, Sankarsan Kampa notifications@github.com, wrote:

Closed #619. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Sixthhokage1 commented 5 years ago

A user's balance of bot currency is more akin to a bank account than a business' accounting ledger. It is more appropriate to use the terms as they would apply to a bank account (debit is a decrease to the balance, credit is an increase to the balance) than to use them in the bookkeeping sense.

iamtraction commented 5 years ago

Well, then, it seems like some commands needs to be rephrased.