[BUG]: apod command does not show embedded video

TheBastionBot / Bastion

🚀 Get an enhanced Discord experience!

https://bastion.traction.one

GNU General Public License v3.0

314 stars 245 forks source link

[BUG]: apod command does not show embedded video #909

Closed Gatowag closed 2 years ago

Gatowag commented 3 years ago

expected behavior: run !apod command to display: title, featured image, and description
observed behavior: runs as expected on days when apod features a photo, but on days where apod features an embedded youtube video, the command only shows title and description (without the video)

To Reproduce

Run the !apod command on days where a video is featured
See error

Screenshots

Environment:

Bastion: self hosted, v8.14.0
Operating System: Debian 9.13

iamtraction commented 3 years ago

Didn't realize APOD features videos as well, considering it's called "Astronomy Picture of the Day". Anyways, I'll implement video support in the next update.

iamtraction commented 3 years ago

As videos are not yet supported by Discord for custom embeds, I tried to use the video URL in the plain text message, but it didn't look good with the rest of the custom embed. Will keep this issue open until video support is added, since #910 has been implemented and users can go to the apod page to view it anyways.

atlanna[bot] commented 2 years ago

If you think this was a mistake, feel free to reopen this isssue.