TheBastionBot / Bastion

🚀 Get an enhanced Discord experience!
https://bastion.traction.one
GNU General Public License v3.0
312 stars 245 forks source link

Message delete / update: display original message / diff #986

Closed sdip15fa closed 1 year ago

sdip15fa commented 1 year ago

Changes

On message delete

On message update

Sample

Screenshot_20221231_180249

atlanna[bot] commented 1 year ago

Thank you for opening this pull request. A maintainer will get by as soon as practical to review the changes.

iamtraction commented 1 year ago

This is intentionally not included. This has been discussed before in the server, so I'll just quote it here:

deleted messages won't be logged. it has been like this from the beginning and i have no plans to change it.

Imagine if a user posts something personal by mistake. If deleted messages were logged, there's no way for this user's personal details to be deleted. It's visible to everyone who can see the deleted logs. Therefore Bastion doesn't log deleted/updated messages.

... the pros of not logging deleted messages outweighs the cons for me.

i'm planning to add it but want to add a way to inform users first.

... if i were to ever add it to bastion, i'll make it opt-in per server and i'd have to add a way of letting users know that their deleted messages will be logged in the server.

sdip15fa commented 1 year ago

Okay, maybe I could make it opt-in

iamtraction commented 1 year ago

I'm still thinking a good way to notify members of the server that their deleted messages will be logged. something like having a /privacy command that users can use to see whether a server has opted in to log deleted messages.

but servers can disable the command for users so probably make it a DM command that users can use in Bastion's DMs.

atlanna[bot] commented 1 year ago

If you think this was a mistake, feel free to reopen this pull request.

sdip15fa commented 1 year ago

I have made it opt-in, and as for the privacy notice, maybe a dm to the user upon joining?