TheBastionBot / Bastion

🚀 Get an enhanced Discord experience!
https://bastion.traction.one
GNU General Public License v3.0
314 stars 245 forks source link

Docker support #989

Closed sdip15fa closed 1 year ago

sdip15fa commented 1 year ago

Support docker using docker-compose.

Image: node:18-alpine

built from source only

mongodb is included

atlanna[bot] commented 1 year ago

Thank you for opening this pull request. A maintainer will get by as soon as practical to review the changes.

iamtraction commented 1 year ago
  1. env var support is currently experimental. only some of them work atm. and the vars could change until it's finalized. so this will break when future framework changes are pushed. https://github.com/TheBastionBot/Bastion/blob/990f5ced4489d4fed686b7c87d02b6db434e9ec2/.env.example#L1-L2
  2. i don't want to include mongodb with the docker image
  3. i already have a simpler version with only Dockerfile ready that I'll push after the env changes are finalized. iirc the image created with it was something like 330MB.
atlanna[bot] commented 1 year ago

If you think this was a mistake, feel free to reopen this pull request.

sdip15fa commented 1 year ago

@iamtraction

  1. changed it to use settings.yaml 😅
  2. mongodb is not included with the docker image, just that docker compose would deploy a mongodb container also
  3. I think docker compose is quite useful (and easy) for setting up / deploying so maybe we could use it with your Dockerfile? 😅(this image is also of similar size, 351MB)
iamtraction commented 1 year ago

sure, when i push my dockerfile we can make your docker compose config work with it.