TheBeastLT / torrentio-scraper

Apache License 2.0
904 stars 108 forks source link

Request - File size limit #131

Closed GIGAkunX closed 1 year ago

GIGAkunX commented 1 year ago

Hey dude. Great work with this addon. I didn't see anyone ask this before but is it possible for you to add a file size limit option/filter as well. Similar to the max results option. Reason being obviously not all devices/internet connections can pull a 80GB movie properly and it's a pain to explain to my parents how to look for a decent sized file (same can be said for every none tech person). For example we have a 4k tv but the TV itself can't connect to my 5GHz wifi only 2.4GHz and thus can't pull a 30GB + movie without buffering. It'll world's easier if a personal limit was set and that way a person can with certainty click the first quality link every single time. Thanks.

tundrablasen commented 1 year ago

+1 on that Request

wood-cottage commented 1 year ago

+1 on this too, this is the only thing keeping me on Kodi/umbrella rather than moving to stremio fully, either a "limit by bitrate" or "limit by xxGB per movie / show" would be fantastic

TheBeastLT commented 1 year ago

I've added an option in the confguration page to configure file size limit. It accepts size in GB and MB, if you want to configure different size limits for movies and series separate different sizes with a comma (first size is for movies, second one after comma is applied for series). Examples: 1.37GB - limits file size for both movies and series to 1.37GB 800MB - limits file size for both movies and series to 800MB 5GB,900MB - limits file size for movies to 5GB and limits file size for series to 900MB

wood-cottage commented 1 year ago

Thank you for this update, that's awesome 👍

tundrablasen commented 1 year ago

Thanks @TheBeastLT

GIGAkunX commented 1 year ago

Thanks dude! 👍

GIGAkunX commented 1 year ago

Hey @TheBeastLT. When you can would you be able look over this change again. It seems to be removing/limiting results that it shouldn't. Specifically when sorted by "Quality then Size". For example when sorted by "Quality then Seeders" with a result limit of "6" and a file size limit of "15GB" and I lookup the movie "Inception", I get "5" 1080p results (amongst the other quality results). 5 out of what should be 6, which is still wrong but acceptable. However with those same settings but change the sort to "Quality then Size", I only get "2" 1080p results (amongst a very small result set for the other resolutions as well).

The "max results per quality" setting seems to have a effect on this as well. When I increase the results to "10" then I actually see "6" results when sorted by "Quality then Size.

Thanks.

TwilightMercy commented 3 weeks ago

@TheBeastLT Can usage explanation be added to configuration page? Via tooltip