TheBenderman / Senior-Design-ALS-Social-Media

5 stars 0 forks source link

Keyboard on Exit does not go back to hometimeline #46

Closed hassanNS closed 7 years ago

hassanNS commented 7 years ago

Navigate to hometimeline. Select a tweet. Hit the reply button. Exit the keyboard. You will see the screen is empty.

KLD commented 7 years ago

Could you show the code on the OnClick for the 'Replay'. What function gets called when Reply is triggered? I want to see the code for that function.

hassanNS commented 7 years ago
twwettttprobls
Pirobi commented 7 years ago

You're not hiding the time line game object after clicking reply, right?

KLD commented 7 years ago

I don't see why the issue is Keyboard.

Edit: I would suggest temporary remove that OnClick that calls the keyboard and test the menu without Keyboard.

hassanNS commented 7 years ago

It's not the keyboard. It's the selection manager or the popping mechanism

KLD commented 7 years ago

Could you should the 'Replay' Button in Inspector. I want to see attached OnClick and Menus.

hassanNS commented 7 years ago
twiteterereply
KLD commented 7 years ago

That's a different function that what we saw above. It should be replayToTweet not TweetFromKeyboard

hassanNS commented 7 years ago

Both have the exact same code. I tried swtiching them around to see if it would make a difference

hassanNS commented 7 years ago

Pressing Exit pops 2 levels and goes back to the multiple tweets selection menu, but nothing shows

Pirobi commented 7 years ago

So if both have the same code, why are there 2 methods? This is a separate issue but still

KLD commented 7 years ago

Show me the Inspector for the menu showed . I think 'OnResume' is not bringing back the menu while 'OnPause' is hiding it.

hassanNS commented 7 years ago

@Pirobi the arguments are different.

hassanNS commented 7 years ago

@KLD0093 which menu. The keyboard?

KLD commented 7 years ago

menu. Keyboard it working as intended.

hassanNS commented 7 years ago

Which menu

hassanNS commented 7 years ago

I know keyboard is working. I want to know how to setup the menu

KLD commented 7 years ago

Show me the Inspector for the menu showed

hassanNS commented 7 years ago
menu

do u mean this

KLD commented 7 years ago

Could you double check if 'OnResume' enables menu?

KLD commented 7 years ago

This is the Selection Manger Logic when it comes to Popping image

Pushing image

I don't see how this would break the timeline menu

hassanNS commented 7 years ago

yes it does

hassanNS commented 7 years ago

do I have to put anything on the reply button itself?

KLD commented 7 years ago

yes it does No it doesn't.

If tweet work properly, but replydoesn't, Then there's something wrong with reply

KLD commented 7 years ago

In run time, check and see how the menu looks like in inspector when it's hidden

hassanNS commented 7 years ago

it's not something wrong w/ reply. It's that tweet is done from the home menu, whereas reply is done from several menus down in the stack.

Pirobi commented 7 years ago

That shouldn't matter as long as everything is pushed onto and popped off the stack properly

hassanNS commented 7 years ago

The pop index for the Exit button on the keyboard is 4

hassanNS commented 7 years ago

so when I pause the scene and manually set the Exit button's pop index to 2, it correctly pops back to the timeline.

hassanNS commented 7 years ago

how does the pop index get set for the keyboard?

KLD commented 7 years ago

Even if you set that to 10, Clicking Exit would navigate back to main menu. In other words, it should not break.

Pirobi commented 7 years ago

Which keyboard do you have set? On mine the exit button is pop index 2

hassanNS commented 7 years ago

again, I want to repeat. It's not "breaking". It's going back to the wrong menu when I hit Exit.

hassanNS commented 7 years ago

and when I change the pop index to 2, it goes back to the correct menu

hassanNS commented 7 years ago

can we do a hangout?

Pirobi commented 7 years ago

If it shows a blank menu, then something is broken. The pop shouldn't pop the twitter main menu.

Pirobi commented 7 years ago

But what keyboard do you have set and which exit button are you hitting?

hassanNS commented 7 years ago

let me put a picture. I didn't set any keyboard beforehand.

KLD commented 7 years ago

isn't it fixed?

Pirobi commented 7 years ago

I just want to confirm the keyboard used

hassanNS commented 7 years ago

no. I have to manually set the pop index to 2 by pasuing the scene.

hassanNS commented 7 years ago
asdfljasldfkj_exit keyboard_bug

1) keyboard 2) exit button

Pirobi commented 7 years ago

That's the wrong keyboard. That's the phrase keyboard.

hassanNS commented 7 years ago

how do I set the right one

Pirobi commented 7 years ago

But, this does mean we have to set that to 2, but the keyboard we will actually be using is correct. Set the right keyboard in the user settings menu, under UI. I think the code defaulted your user settings to that keyboard before I updated it to default to the new one. Since you had this keyboard set already, it didn't update your default.

Pirobi commented 7 years ago

Steps:

  1. Click on the gear at the top-right
  2. Click UI Settings
  3. At the keyboard dropdown, select GridKeyboard.
  4. Save settings
hassanNS commented 7 years ago

yeah, though the user settings menu doesn't have an option to set the pop level (not that I think it should)

Pirobi commented 7 years ago

That's set on the keyboard prefab

Pirobi commented 7 years ago

I'll make that change.

Pirobi commented 7 years ago

I think this can be closed once @hassanNS confirms he has the right keyboard and exiting works.