TheBeruriahIncident / openid4java

Automatically exported from code.google.com/p/openid4java
Apache License 2.0
0 stars 0 forks source link

Status message is only set if debug logging is enabled #165

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In ConsumerManager.java on line 1793 there is a call to result.setStatusMsg, 
but that call is only executed, if DEBUG is true. Need to move the call out of 
the if block, i.e. replace the code:

else if (DEBUG)
            {
                _log.debug("Local signature verification failed.");
                result.setStatusMsg("Local signature verification failed");
            }

with code:

else 
            {
                if (DEBUG)
                    _log.debug("Local signature verification failed.");
                result.setStatusMsg("Local signature verification failed");
            }

Original issue reported on code.google.com by viliam.d...@gmail.com on 21 Sep 2011 at 10:57

GoogleCodeExporter commented 9 years ago
Here is a patch. 

Original comment by viliam.d...@gmail.com on 22 Sep 2011 at 6:20

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed in r689.

Original comment by Johnny.B...@gmail.com on 31 Oct 2012 at 9:03