search

TheBevyFlock / bevy_cli

A Bevy CLI tool.
Apache License 2.0
32 stars 6 forks source link

Make `bevy_lint` call Clippy instead of `cargo check` #33

Closed BD103 closed 3 weeks ago

BD103 commented 2 months ago

RE "When bevy lint is called, it will call RUSTC_WORKSPACE_WRAPPER=path/to/bevy_lint_driver cargo check. " - should the linter have the ability to run clippy instead of just check?

_Originally posted by @callym in https://github.com/TheBevyFlock/bevy_cli/issues/7#issuecomment-2327308807_

BD103 commented 2 months ago

See my comment in https://github.com/TheBevyFlock/bevy_cli/issues/7#issuecomment-2327677374 as well. I think this is possible, but low priority for now!

BD103 commented 3 weeks ago

I'm going to mark this as "not planned". While Clippy is certainly useful, it:

  1. Is not guaranteed to always be installed, leading to confusing error messages or weird fallbacks.
  2. May slow down the time it takes to check a project, when the caller may not want those lints.
  3. Clutters up the terminal with warnings the user may not care about, decreasing the value of actual Bevy lints.

I'm open to reconsider this if anyone has reasons for using Clippy!