search

TheBigBrainsCompany / TbbcMoneyBundle

This bundle is used to integrate the Money library (https://github.com/mathiasverraes/money) into a Symfony project. This library is based on Fowler's Money pattern (https://verraes.net/2011/04/fowler-money-pattern-in-php/)
MIT License
192 stars 74 forks source link

Resolve concurrency issues when fetching ratios from provider #137

Closed johanwilfer closed 12 months ago

johanwilfer commented 2 years ago

This resolves a concurrency issue we have observed when ratios are removed and then inserted again. Instead we now update existing rows.

It also adds compatibility with Symfony 4/5, this branch from me was merged https://github.com/TheBigBrainsCompany/TbbcMoneyBundle/pull/123 with Symfony 3.4 compatibility as merged but it actually breaks symfony 4/5 compatibility that we use now (can only blame myself).

The real solution for that is probably #136, it seems impossible to maintain compatibility with Symfony all of 3/4/5 here, so maybe these changes should not even be merged here, and rather the #136 should be merged for Symfony 5/6 compatibility instead.

johanwilfer commented 2 years ago

I will update this branch as sf6 support is merged to master and released now.

johanwilfer commented 12 months ago

Will close this one, see: https://github.com/TheBigBrainsCompany/TbbcMoneyBundle/pull/143