search

TheBigBrainsCompany / TbbcMoneyBundle

This bundle is used to integrate the Money library (https://github.com/mathiasverraes/money) into a Symfony project. This library is based on Fowler's Money pattern (https://verraes.net/2011/04/fowler-money-pattern-in-php/)
MIT License
192 stars 74 forks source link

Remove Yahoo & Google ratio providers #145

Closed hhamon closed 11 months ago

hhamon commented 11 months ago

Both classes don't exist in the repository but they were referenced in services.xml file.

This makes running the lint:container command fail within a Symfony 5/6 project:

php bin/console lint:container

In AbstractRecursivePass.php line 176:

  Invalid service "tbbc_money.ratio_provider.yahoo_finance": class "Tbbc\MoneyBundle\Pair\RatioProvider\YahooFinanceRatioProvider" does not exist.

lint:container
hhamon commented 11 months ago

Ping @armetiz @borisguery :)

armetiz commented 11 months ago

Hello @hhamon ! C'est principalement @philippe-levan qui gère et utilise ce repository.

hhamon commented 11 months ago

Hello @armetiz !

Je laisse @philippe-levan prendre le soin de revoir la MR dans ce cas :)

philippe-levan commented 11 months ago

Hello @hhamon ! C'est principalement @philippe-levan qui gère et utilise ce repository.

I'm not the main maintainer anymore on this bundle ! thanks @johanwilfer for the merge & tag !