search

TheBlueMatt / RelayNode

A block-compressing fast relay server/client
http://bitcoinrelaynetwork.org
MIT License
84 stars 49 forks source link

Relaynode no longer identifies its User Agent and gets disconnected. #20

Closed jedimstr closed 8 years ago

jedimstr commented 8 years ago

I just pulled the Oct 20th commits including: 9b326ec071dd03be74d2496f251b6ac76596ab1d After making the new C++ client node and starting it, all seems fine from the client, but my -nowallet bitcoin node used for mining on p2pool sees an issue. The relay client connects without a User Agent and NA ping time, and then after a minute or so disconnects totally (no longer on peer list). The node running log shows no issues. Previous version connected with an identifying User Agent and stayed connected.

jedimstr commented 8 years ago

So I had to go back a few commit versions until I found one that worked again. Apparently the last one that identified the /RelayNetworkClient:42/ as User Agent and stayed connected was commit: ddd0829a1ecf69110a7140ebd23ec982ad8b16cf back in September.

p3yot3 commented 8 years ago

Hi jedimstr,

Strange, it's working fine on my node with no issues......

TheBlueMatt commented 8 years ago

Strange, I cant seem to reproduce...Are you suggesting a51c67e74fe88de51383dfee436646ce4d7a714f broke your connection? It shouldnt be able to effect client stuff at all? Have you tried 5da6c4f9fc305e37003c08dbb0d8b14509385871?

jedimstr commented 8 years ago

Yup, pretty much.

Here are screenshots of the behavior.

First with ddd0829a1ecf69110a7140ebd23ec982ad8b16cf

bitcoin_core_-_node

Then showing my checkout and build of a51c67e74fe88de51383dfee436646ce4d7a714f

jedimstr_ _screen_0__zsh____jedimstr_cylonbasestar___relaynode_c_____121x77___pts_16_ _ssh_ _ttys001

Then on startup this empty UserAgent for same IP shows:

bitcoin_core_-_node 2

And then after about a minute or so, it disappears from Bitcoin Core's list:

bitcoin_core_-_node 3

But the running log keeps on going as if it's still connected:

jedimstr_ _screen_0____relaynetworkclient____jedimstr_cylonbasestar___relaynode_c_____121x77___pts_16_ _ssh_ _ttys001

The RelayNetworkClient is running on Ubuntu and the Bitcoin Core node version v0.11.1 set to nowallet is running on a Mac.

Every version committed after ddd0829a1ecf69110a7140ebd23ec982ad8b16cf is broken like this, and I've tried every one including 5da6c4f9fc305e37003c08dbb0d8b14509385871 with no success.

Reverting back to ddd0829a1ecf69110a7140ebd23ec982ad8b16cf has the client reporting correctly in Bitcoin Core and staying connected.

TheBlueMatt commented 8 years ago

I really dont see how that could be...a51c67e74fe88de51383dfee436646ce4d7a714f added only about three LOC that should be NOPs for clients (it was mostly a server commit). Still, I pushed some other stuff I had been testing, so try current master?

jedimstr commented 8 years ago

Whatever you added in your new commits fixed it. Pulled and checked out master (back to HEAD which is 78274d9846cb1e505218bcc9e65fc440dabcb9c1 ) and it's showing the correct UserAgent and staying connected again. So maybe something was amiss in your previous KeepAlive stuff?

TheBlueMatt commented 8 years ago

Strange, closing, then.