search

TheBoegl / gradle-launch4j

A gradle-plugin to create windows executables with launch4j
Apache License 2.0
311 stars 42 forks source link

Property jar is ignored in v2.5.0 #109

Closed maikelsteneker closed 3 years ago

maikelsteneker commented 3 years ago

See my example repository at https://github.com/maikelsteneker/gradle-launch4j-mwe.

This is an issue I discovered when upgrading from v2.4.9 to v2.5.0.

I'm creating a jar file without an extension (unusual, I know).

I'm using the following to set the jar that is to be used for launch4j:

tasks.withType<DefaultLaunch4jTask> {
    jar = "TICS"
}

Using ./gradlew createExe -Pl4j-debug, I inspect the XML that's generated. For v2.4.9, the jar property is set as I expect it: <jar>TICS</jar> After upgrading to v2.5.0, this property seems to be ignored: <jar>TICS</jar>

I'm aware that this property is deprecated and I should be using jarTask instead, but it would be good to preserve this functionality for backwards compatibility purposes. Alternatively, if this is not a valid use case, an error message would be helpful.

TheBoegl commented 3 years ago

This should be fixed on the next release with @naftalmm commit in e9924880

TheBoegl commented 3 years ago

fixed in #111 and published in version 2.5.1