search

TheBoegl / gradle-launch4j

A gradle-plugin to create windows executables with launch4j
Apache License 2.0
305 stars 42 forks source link

fix jcenter deprecation warning for projects applying this plugin #112

Closed naftalmm closed 3 years ago

naftalmm commented 3 years ago

Applying plugin in projects using Gradle 7.x results in a warning:

> Configure project :
The RepositoryHandler.jcenter() method has been deprecated. This is scheduled to be removed in Gradle 8.0. JFrog announced JCenter's shutdown in February 2021. Use mavenCentral() instead. Consult the upgrading guide for further information: https://docs.gradle.org/7.0.2/userguide/upgrading_version_6.html#jcenter_deprecation
    at org.gradle.api.internal.artifacts.dsl.DefaultRepositoryHandler.deprecateJCenter(DefaultRepositoryHandler.java:130)
    at org.gradle.api.internal.artifacts.dsl.DefaultRepositoryHandler.jcenter(DefaultRepositoryHandler.java:114)
    at edu.sc.seis.launch4j.Launch4jPlugin.configureDependencies(Launch4jPlugin.groovy:89)
    at edu.sc.seis.launch4j.Launch4jPlugin.apply(Launch4jPlugin.groovy:60)
    at edu.sc.seis.launch4j.Launch4jPlugin.apply(Launch4jPlugin.groovy)

This PR resolves this warning by changing the repository to retrieve the launch4j from jcenter to mavenCentral.

This partly resolves #107

maikelsteneker commented 3 years ago

Would it be possible to get a new version of gradle-launch4j with this change included? It would be nice to use Gradle 7.x without warnings before version 3.0 is released.