search

TheBoegl / gradle-launch4j

A gradle-plugin to create windows executables with launch4j
Apache License 2.0
305 stars 42 forks source link

Issue #117 Entry <xxx> is a duplicate but no duplicate handling strategy has been set #123

Closed Shadow-Devil closed 1 year ago

Shadow-Devil commented 1 year ago

This is currently only a draft since it doesn't allow the configuration of the DuplicationStrategy. It just hardcodes the strategy EXCLUDE.

Shadow-Devil commented 1 year ago

I tried to add a new parameter for the duplicatesStrategy, but I'm not sure if it works or anything else needs to be added (The test worked, but I didn't validate that the specified strategy is being used).

TheBoegl commented 1 year ago

Thanks for creating this PR. Please add the parameter to the REAMDE.MD's configuration section with a short description and the used default value. Furthermore, please add a test method for the default behavior i.e. without providing the duplicatesStrategy. You could add another test method with DuplicatesStrategy.FAIL and assert that it fails to create the exe, but IMHO this only tests gradle's implementation and not the code in this PR and, thus, is unnecessary.

Shadow-Devil commented 1 year ago

Hi @TheBoegl I think this should be ready. Could you please review the Pull Request?