Proposed fix for issue 143

TheBoegl / gradle-launch4j

A gradle-plugin to create windows executables with launch4j

Apache License 2.0

305 stars 42 forks source link

Proposed fix for issue 143 #145

Closed etschelp closed 1 year ago

etschelp commented 1 year ago

see: https://github.com/TheBoegl/gradle-launch4j/issues/143

Tested against Gradle 8, but I could only make this work on the Gradle 7 branch. There are a lot of warnings on that branch, so I'm not sure if there aren't more issues regarding Gradle 8.

TheBoegl commented 1 year ago

Thanks for this PR. I'll try to take a look at it and the other issues tomorrow if I have time.

TheBoegl commented 1 year ago

I had to rework this PR to get the dependencies for the jarTask to work as expected and fix the failing tests cases especially the ones in backwardsCompatibiltyTest. Thanks to your PR, which helped me to get a fix for #143 that I've pushed it into develop, though I had to drop support for gradle < 4.4.