search

TheBrainFamily / wait-for-expect

Wait for expectation to be true, useful for integration and end to end testing. Integral part of react-testing-library.
MIT License
293 stars 31 forks source link

feat: configurable default timeout and interval #18

Closed mmkal closed 5 years ago

mmkal commented 5 years ago

Hey - love the library! This is a very small PR to allow setting the default timeout and interval globally.

Was going to make an issue but I thought this was simple enough that a PR would be about as easy. Obviously up to you if you want this to go in - it's possible to workaround by wrapping this library's export, but I found myself doing that in a lot of projects, so I wondered if you'd be open to supporting it out-of-the box.

Side note - I noticed there's a file src/index.d.ts, but I'm not sure what this does, since the declaration files are generated by npm run build (which outputs lib/index.d.ts, matching what's in package.json). I left it, but it could probably be safely deleted, along with the other *.d.ts files under src.

lgandecki commented 5 years ago

Looks good, thank you! And sorry for the lag - I didn't notice this PR somehow.

lgandecki commented 5 years ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: