search

TheBusyBiscuit / CS-CoreLib2

This is an updated (LITE) Version of CS-CoreLib. Instead of being a hard dependency, it should be shaded instead.
MIT License
19 stars 18 forks source link

No longer cooperating with GriefPrevention #124

Open mrcoffee1026 opened 3 years ago

mrcoffee1026 commented 3 years ago

Description (Required)

GriefPrevention is a supported protection plugin that has 3 main levels of trust that can be granted to a player: /trust (build (grants containertrust and accesstrust)), /containertrust (container accesss (grants accesstrust level)) and /accesstrust (buttons and levers). Somewhere around the time 1.16 came about, either due to GriefPrevention updating for 1.16 or due to MC itself updating, the "containertrust" level no longer grants access to Slimefun machines. The only workaround I can find is to provide the slimefun.inventory.bypass permission to allow users access into another users machine, except that this permission allows all users unfettered access to ALL slimefun machines, not only the one they are intended to have access to.

Steps to reproduce the Issue (Required)

Create GriefPrevention claim and place any Slimefun electric machine within it and /containertrust [playername] then have that player try to open the interface: they will receive this message in chat: denied

Expected behavior (Required)

Access should be allowed to Slimefun machines if the user has been granted accesstrust or trust within the GriefPrevention claim.

Server Log / Error Report

No errors.

Server specs (Required)

[09:38:28 INFO]: Paper v1_16_R3 [09:38:28 INFO]: CS-CoreLib vDEV - 92 (git e9150d72) [09:38:28 INFO]: Slimefun vDEV - 763 (git 96e38608) [09:38:28 INFO]: Metrics build: #17 [09:38:28 INFO]: [09:38:28 INFO]: Installed Addons: (29) [09:38:28 INFO]: GlobalWarming vDEV - 4 (git bd8e730a) [09:38:28 INFO]: SlimyPowerSuits vDEV - 8 (git a93bd3ae) [09:38:28 INFO]: ExtraTools vDEV - 22 (git ea11f88b) [09:38:28 INFO]: FoxyMachines vDEV - 7 (git 85598948) [09:38:28 INFO]: SlimefunOreChunks vDEV - 10 (git 91df3b8e) [09:38:28 INFO]: SensibleToolbox vDEV - 34 (git 3653e8c6) [09:38:28 INFO]: ExtraGear vDEV - 12 (git 4570ea2c) [09:38:28 INFO]: MoreTools vDEV - 8 (git db8d8814) [09:38:28 INFO]: InfinityExpansion vDEV - 50 (git 255cc995) [09:38:28 INFO]: SFCalc vDEV - 14 (git 8d205b67) [09:38:28 INFO]: ElectricSpawners vDEV - 18 (git f9da206b) [09:38:28 INFO]: ExtraHeads vDEV - 18 (git ec4e19f2) [09:38:28 INFO]: MobCapturer vDEV - 11 (git 4edf38dd) [09:38:28 INFO]: SlimyTreeTaps vDEV - 15 (git 205f8afc) [09:38:28 INFO]: PrivateStorage vDEV - 15 (git a0fbc572) [09:38:28 INFO]: TranscEndence vDEV - 21 (git f7bb1376) [09:38:28 INFO]: FluffyMachines vDEV - 48 (git 174f1cdb) [09:38:28 INFO]: CMI v8.7.11.1 [09:38:28 INFO]: ChestTerminal vDEV - 38 (git c024be5c) [09:38:28 INFO]: DyedBackpacks vDEV - 11 (git b8eda0c7) [09:38:28 INFO]: SoundMuffler vDEV - 17 (git 3abf8993) [09:38:28 INFO]: SlimefunWarfare vDEV - 10 (git c4839f3c) [09:38:28 INFO]: EcoPower vDEV - 2 (git b0c0c875) [09:38:28 INFO]: HotbarPets vDEV - 32 (git 977f0591) [09:38:28 INFO]: SlimefunLuckyBlocks vDEV - 30 (git 26824119) [09:38:28 INFO]: ExoticGarden vDEV - 62 (git 9cbd372e) [09:38:28 INFO]: Liquid vDEV - 2 (git a1e713d8) [09:38:28 INFO]: LiteXpansion vDEV - 98 (git f79eab2f) [09:38:28 INFO]: SoulJars vDEV - 18 (git 098ad836)

FULL plugins list (Required)

Actually affected: GriefPrevention 16.16.0 [09:40:24 INFO]: Plugins (103): Advanced_Drop_Party, AdvancedRegionMarket, AntiCommandSuggestions, ArmorStandEditor, AsyncWorldEdit, AuctionGUIPlus, Boss, BossShopPro, BottledExp, Brewery, ChatControl, ChestShop, ChestTerminal, CMI, CMIPaperLib, CommandSigns, Confiscate, CoreProtect, CratesPlus, CS-CoreLib, DyedBackpacks, EcoPower, ElectricSpawners, EnchantableBlocks, EnjinMinecraftPlugin, EntityDetection, Essentials, EssentialsAntiBuild, EssentialsGeoIP, EssentialsProtect, EssentialsSpawn, ExoticGarden, ExtraContexts, ExtraGear, ExtraHeads, ExtraTools, FluffyMachines, FlyingCarpet, FoxyMachines, GlobalWarming, GriefPrevention, HackedCore, HackedServer, HeapDump, HorseTpWithMe, HotbarPets, InfinityExpansion, Jobs, LibsDisguises, Liquid, LiteXpansion, LuckPerms, LWC, Marriage, MineableSpawners, MobCapturer, MoreTools, Multiverse-Core, Multiverse-Inventories, Multiverse-NetherPortals, Multiverse-Portals, OpenInv, PlaceholderAPI, PlayerLogger, PlayerPoints, PlotSquared, PowerNBT, PremiumVanish, PrivateStorage, ProtocolLib, RedstoneClockDetector, SelectionVisualizer, SensibleToolbox, SFCalc, SimplePets, SkinsRestorer, Slimefun, SlimefunLuckyBlocks, SlimefunOreChunks, SlimefunWarfare, SlimyPowerSuits, SlimyTreeTaps, SnowballDamage, SoulJars, SoundMuffler, SpecTPRestrictions, StackMob, TARDIS, TARDISChunkGenerator, TARDISVortexManipulator, TARDISWeepingAngels, TranscEndence, UltimateTimber, UltimateVotes, VampireRevamp, Vault, Votifier, Werewolf, Wild, WorldBorder, WorldEdit, WorldGuard, WorldGuardExtraFlags

ItsSynchro commented 3 years ago

Can confirm this is also the case with Towny whilst using any build above #739. However, I don't think its CS-CoreLib, but instead Slimefun4.

WalshyDev commented 3 years ago

CS-CoreLib2 is what handles it. SF just implements the check. AFAIK that hasn't changed in SF but changed slightly here recently. However, I can't see the issue from a quick look

mrcoffee1026 commented 3 years ago

Have further determined that it goes beyond just not having the ability to share machines, tools that would break blocks on into GriefPrevention claims are no longer prevented from destroying those blocks either.

mrcoffee1026 commented 3 years ago

More recently: "Lockable" blocks now cooperate with Griefprevention (Machines like the Smeltery, which utilize a Furnace block... generally lockable with other plugins) are now properly accessible, whereas machines like Disenchanters and Ingot Factories still are not. Also note that Griefprevention has been updated to 16.17.1

mrcoffee1026 commented 3 years ago

Still a severe issue, many users cannot open their own machines!