TheBusyBiscuit / CS-CoreLib2

This is an updated (LITE) Version of CS-CoreLib. Instead of being a hard dependency, it should be shaded instead.
MIT License
19 stars 18 forks source link

Borders of BentoBox islands are not respected #97

Open andris155 opened 4 years ago

andris155 commented 4 years ago

Description (Required)

Slimefun Androids can go out from BentoBox islands.

Steps to reproduce the Issue (Required)

  1. Give and place an Slimefun Programmable Android.
  2. Set script, move forward, repeat.
  3. Put fuel and start Android.
  4. Android go out from BentoBox island.

2020-07-26_23 38 59

Expected behavior (Required)

Slimefun Programmable Androids can't go out from BentoBox islands.

Server Log / Error Report

Server specs (Required)

FULL plugins list (Required)

Plugins (15): BentoBox, CS-CoreLib, Essentials, EssentialsChat, EssentialsSpawn, GriefPrevention, LuckPerms, Multiverse-Core, PlotSquared, PlugMan, ProtocolLib, Slimefun, Vault, WorldEdit, WorldGuard

TheBusyBiscuit commented 4 years ago

@Poslovitch

Poslovitch commented 4 years ago

Hi, There is no method in the ProtectionModule that would allow me to prevent that. Am I missing something?

TheBusyBiscuit commented 4 years ago

Well, this should be handled by the hasPermission method, like everything else. Normally it should fall under ProtectableAction.PLACE_BLOCK.

Poslovitch commented 4 years ago

Alright, good to know.