search

TheButlah / ovr_overlay

Rust OpenVR bindings using an up-to-date OpenVR and autocxx
https://docs.rs/ovr_overlay
Other
7 stars 8 forks source link

Initial bindings for input subsystem. #6

Closed kitlith closed 1 year ago

kitlith commented 2 years ago

Includes most things that the feeder app/overlay wants, aside from GetOriginLocalizedName (which needs a bitset I haven't implemented yet).

Currently using types directly from sys, might want to wrap some of these types.

PR is currently a draft, because at the very least there is one more function I intend to implement, then I'll work on wrappers for types from sys.

kitlith commented 2 years ago

Marking as ready for review. I'm not going to bother to implement GetOriginLocalizedName at the current time, since we're not working on porting the feeder over to rust quite yet.

This means the main obstacle for this PR at the moment is the direct usage of sys::* types.

TheButlah commented 2 years ago

I might not have time to review this as I'm about to go on vacation. How high priority is it for me to review? That will help me figure out where/when to fit in the review.

kitlith commented 2 years ago

Not very high, since there's still some sys:: types being used that I know that you'll want fixed. The point of marking it as reading for review is to say "hey, this isn't blocked on me coming back and implementing a method i said i was going to implement before".

Enjoy your vacation, don't worry about it.