TheButlah / ovr_overlay

Rust OpenVR bindings using an up-to-date OpenVR and autocxx
https://docs.rs/ovr_overlay
Other
7 stars 8 forks source link

Initial implementation of ChaperoneSetup::ExportLiveToBuffer #9

Closed kitlith closed 1 year ago

kitlith commented 1 year ago

Currently just returning CString, we probably want to turn that into a string (or whatever is most convienent to pass to a json parser)

TheButlah commented 1 year ago

Will review later this week

kitlith commented 1 year ago

I never ran clippy, but I believe all of it is in code I haven't touched here. We probably want to look into a way to prevent clippy from warning on the autogenerated code in the sys crate.

TheButlah commented 1 year ago

I believe all of it is in code I haven't touched here

image Arent these on the diff of this PR?

kitlith commented 1 year ago

blinks oops i misread the output in my terminal. sorry.