covers1624
commented
8 years ago Spawners for 1.10 in NEI were never finished, ive commented out its ASM and it will be replaced with events, Not sure about the ItemStack stuff, works fine with my stuff. Regarding ASM as a whole, im in the process of moving all of CB's stuff away from being a coremod, and NEI is actually next on the list. Regarding why NEI exists at all in 1.10, after many talks with @mezz we decided it would be best for NEI to "Re Skin" JEI, so JEI will be in control of the recipes and such and NEI will add back the widgets. It will require a full rewrite to reach this stage but knocking out the ASM is the first step and once it is gone it should be a lot easier to move it to the pure widgets state.
mezz
jredfox
This mod breaks any entity items spawning in if the entity item is instanceof BlockMobSpawner entity item. I have made silk spanwers fully working with 1.10.2 and it won't spawn in the entity item if the NEI is loaded. It works perfectly fine without it. Entity item is an item on the ground. It works perfectly without it spawning in the itemstack if NEI isn't loaded. This isn't on my side why is nei using asm to prevent entity items from spawning in? Use event handler to read the tile entity not asm to break the game and prevent any entity item from spawning in.
Code: https://gist.github.com/jredfox/e3167722ae861d8b16665e6b66971521
problem two and three it breaks the vanilla translation stack override both of tooltips and display name overrides
@Override public String getItemStackDisplayName(ItemStack stack) { //event doesn't get fired or doesn't work System.out.println("Test"); }
@SideOnly(Side.CLIENT) public void addInformation(ItemStack stack, EntityPlayer player, List list, boolean torf) { //event doesn't get fired or doesn't work System.out.println("Test"); }
So where is this CB project manager that you were talking about I can't find him anywhere. Why is this mod modifying spawners since NEI no longer modifies anything having to do with spawners in 1.10.2 so why is it modifying the entity items in the spawners and blocking tooltips, and name display overrides
As of 1.10.2 update for NEI is now incompatible with my mod silk spawners the code for the block drop is above but, here is my forum as well.
http://www.minecraftforum.net/forums/mapping-and-modding/minecraft-mods/2743544-silk-spawners-not-enough-items-support
Note this mod also no longer deals with adding mob spawners to the JEI tabs so why is it that this is breaking mob spawners to?
Question why is NEI even a thing since JEI still works without it? If you were making item stacks to read modded and vanilla mob spawners again like in 1.8 and 1.7.10 I would understand but, you don't so is this in a beta state? If you do add the mob spawners back don't use asm use on block place method and support nbt tag compounds for sub entites support. Get the block at it's position if instanceof block mob spawner have a tag compound that system that goes in parallel with vanilla's and then make the tile entity read it then it will update it. If you no longer want to modify spawners then why is it that you are breaking them still to make it impossible for any entity item instanceof block mob spawner from spawning in?
/give @p mob_spawner 1 0 {BlockEntityTag:{SpawnData:{id:"Creeper"}, SpawnPotentials:[0:{Entity:{id:"Creeper"},Weight:1}] }}
that will work with cheats enabled for 1.10.2+ however if you want it to work in survival without cheats simply make it read the tile entity without the restrictions like in my code. I don't understand why you modify the spawner breaking any mod compatibility along with not doing what you did in 1.8 and 1.7.10.