TheCGO / fiscalsim-us

FiscalSim US is a microsimulation model of the US federal and state tax and benefit system relating to households and individuals.
https://thecgo.github.io/fiscalsim-us/
GNU Affero General Public License v3.0
9 stars 12 forks source link

new branch now that the repository is public #33

Closed austinperryfrancis closed 10 months ago

austinperryfrancis commented 1 year ago

Hey Rick, let me know how these changes look. I still need to add the logic to compare the age deduction.

rickecon commented 10 months ago

@austinperryfrancis. I think the only thing we need to do to get this PR merged in is for you to update your branch with the new changes.

rickecon commented 10 months ago

@austinperryfrancis. Also, I need you to open the changelog_entry.yaml file, which should be empty in your fiscalsim-us branch, and update it with something like the following:

- bump: minor
  changes:
    added:
      - Added Virginia state income tax logic with credits and refunds
codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 56.61% and project coverage change: -0.72% :warning:

Comparison is base (cd41b35) 97.36% compared to head (6158d0f) 96.64%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #33 +/- ## ========================================== - Coverage 97.36% 96.64% -0.72% ========================================== Files 1354 1379 +25 Lines 21033 21411 +378 Branches 161 195 +34 ========================================== + Hits 20478 20692 +214 - Misses 534 698 +164 Partials 21 21 ``` | [Files Changed](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO) | Coverage Δ | | |---|---|---| | [...ariables/gov/states/tax/income/state\_income\_tax.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3RheC9pbmNvbWUvc3RhdGVfaW5jb21lX3RheC5weQ==) | `100.00% <ø> (ø)` | | | [...come/state\_income\_tax\_before\_refundable\_credits.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3RheC9pbmNvbWUvc3RhdGVfaW5jb21lX3RheF9iZWZvcmVfcmVmdW5kYWJsZV9jcmVkaXRzLnB5) | `100.00% <ø> (ø)` | | | [...come/household/household\_refundable\_tax\_credits.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9ob3VzZWhvbGQvaW5jb21lL2hvdXNlaG9sZC9ob3VzZWhvbGRfcmVmdW5kYWJsZV90YXhfY3JlZGl0cy5weQ==) | `52.94% <ø> (ø)` | | | [...usehold/household\_tax\_before\_refundable\_credits.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9ob3VzZWhvbGQvaW5jb21lL2hvdXNlaG9sZC9ob3VzZWhvbGRfdGF4X2JlZm9yZV9yZWZ1bmRhYmxlX2NyZWRpdHMucHk=) | `50.00% <ø> (ø)` | | | [...ables/gov/states/va/tax/income/va\_age\_deduction.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3ZhL3RheC9pbmNvbWUvdmFfYWdlX2RlZHVjdGlvbi5weQ==) | `16.98% <16.98%> (ø)` | | | [...income/va\_tax\_credit\_for\_low\_income\_individuals.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3ZhL3RheC9pbmNvbWUvdmFfdGF4X2NyZWRpdF9mb3JfbG93X2luY29tZV9pbmRpdmlkdWFscy5weQ==) | `24.32% <24.32%> (ø)` | | | [...es/gov/states/va/tax/income/va\_adj\_gross\_income.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3ZhL3RheC9pbmNvbWUvdmFfYWRqX2dyb3NzX2luY29tZS5weQ==) | `34.61% <34.61%> (ø)` | | | [...ariables/gov/states/va/tax/income/va\_exemptions.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3ZhL3RheC9pbmNvbWUvdmFfZXhlbXB0aW9ucy5weQ==) | `36.00% <36.00%> (ø)` | | | [...variables/gov/states/va/tax/income/calc\_line\_14.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3ZhL3RheC9pbmNvbWUvY2FsY19saW5lXzE0LnB5) | `47.36% <47.36%> (ø)` | | | [...ariables/gov/states/va/tax/income/va\_income\_tax.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3ZhL3RheC9pbmNvbWUvdmFfaW5jb21lX3RheC5weQ==) | `52.94% <52.94%> (ø)` | | | ... and [19 more](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/33?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO) | |

:umbrella: View full report in Codecov by Sentry.

:loudspeaker: Have feedback on the report? Share it here.

rickecon commented 10 months ago

Thanks @austinperryfrancis. This looks great. I don't know why the Lint tests are failing, as we created a fresh conda environment and ran the black and linecheck tests. And we still need to write tests for the variables in Virginia. Merging.