Closed austinperryfrancis closed 10 months ago
@austinperryfrancis. I think the only thing we need to do to get this PR merged in is for you to update your branch with the new changes.
main
branch and do a git fetch upstream
and git merge upstream/main
git push origin main
.main
branch is updated, navigate to your va
branch.
main
branch into the va
branch: git merge origin/main
va
branch. This will automatically update your PR.@austinperryfrancis. Also, I need you to open the changelog_entry.yaml
file, which should be empty in your fiscalsim-us
branch, and update it with something like the following:
- bump: minor
changes:
added:
- Added Virginia state income tax logic with credits and refunds
Patch coverage: 56.61%
and project coverage change: -0.72%
:warning:
Comparison is base (
cd41b35
) 97.36% compared to head (6158d0f
) 96.64%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @austinperryfrancis. This looks great. I don't know why the Lint tests are failing, as we created a fresh conda environment and ran the black and linecheck tests. And we still need to write tests for the variables in Virginia. Merging.
Hey Rick, let me know how these changes look. I still need to add the logic to compare the age deduction.