UPDATED VA LOGIC

[austinperryfrancis]

Hey Rick! I created the Va Exemption logic. I did a lot of digging to look for the correct input variables, and so I hope I did it right. Looking forward to your review.

[rickecon]

@austinperryfrancis. Nice. Now it is passing three sets of tests. And I can pull your repo as a branch to my repository.

You can fix the Lint test by going to your branch, typing make format, then seeing what files format were updated git status, then adding those files to this PR git add -A, then committing those files to this PR git commit -m "Black and linecheck formatted files", then push those changes to the your remote fork of this PR git push origin va. Once you do that, the Lint tests will pass. The make format command executes the two format lines in the Makefile file in the main level of the repository. It is like typing those two lines in your terminal.

[austinperryfrancis]

@rickecon Great, I just did the make format changes and the requested pull request. it looks like the Lint test still failed.

[rickecon]

@austinperryfrancis. Will you please make the following updates to this PR? I am going to try and get it reviewed by Saturday night.

• Incorporate the new changes to the main branch of the repository into your va branch.
  • In your terminal, navigate to your fiscalsim-us directory. Switch branches to your main local branch: git checkout main
  • Fetch the changes to the TheCGO/fiscalsim-us main branch: git fetch upstream
  • Merge the recent changes to the TheCGO/fiscalsim-us main branch into your main branch: git merge upstream/main
  • Push these changes to your remote fork: git push origin main
  • Now switch branches to your va branch: git checkout va
  • And merge the changes you made to your main branch into your va branch: git merge origin/main
  • Push those changes to your remote fork va branch: git push origin va
• Update your fiscalsim-us conda environment.
  • From your terminal in the fiscalsim-us directory, deactivate your current environment so you are in the base conda environment: conda deactivate
  • Delete your existing fiscalsim-us conda environment: conda remove --name fiscalsim-us --all
  • Create a new conda environment that uses Python 3.9: conda create -n fiscalsim-us python=3.9
  • Activate the new conda environment: conda activate fiscalsim-us
  • Install the development version of the fiscalsim-us package into this conda environment (code instruction for Windows machine): pip install -e ."[dev]"
• With the fiscalsim-us conda environment activated and in your local fiscalsim-us/ directory and in your va branch, run make format.
  • When this is done, type git status to see if the format of any of your files in the va branch have changed.
  • If files changed, git add -A those files, and git commit -m "Black and linecheck formatted files" them, andgit push origin va` them.

Completing these steps will get your PR in the shape I need it to check it. Let me know when you are done.

[rickecon]

@austinperryfrancis. In the VA income tax [instructions]() on page 10, I wonder if we should parameterize the rounding rule under the heading "Dollar Amounts".

All amounts entered on your return must be rounded to the nearest dollar. Amounts less than 50 cents should be rounded down while all amounts of 50 cents - 99 cents should be rounded up. Rounding to the nearest dollar improves accuracy and reduces processing time.