TheCGO / fiscalsim-us

FiscalSim US is a microsimulation model of the US federal and state tax and benefit system relating to households and individuals.
https://thecgo.github.io/fiscalsim-us/
GNU Affero General Public License v3.0
9 stars 12 forks source link

Corrected Kansas SD for WIDOW filing status #45

Closed patneyland closed 1 year ago

patneyland commented 1 year ago

Changed the standard deduction amount for WIDOW filing status for Kansas. It was previously the same as JOINT, when it should have been the same as HEAD_OF_HOUSEHOLD.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (c92d78d) 97.17% compared to head (099c752) 97.17%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #45 +/- ## ======================================= Coverage 97.17% 97.17% ======================================= Files 1237 1237 Lines 19579 19579 Branches 158 158 ======================================= Hits 19026 19026 Misses 533 533 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rickecon commented 1 year ago

@patrickneyland. This looks great. The last thing you need for this PR is to add the following text into the changelog_entry.yaml file. This will let the model automatically update the version number and will make the "Check version" CI test pass.

- bump: patch
  changes:
    changed:
      - Updated the value for the Kansas standard deduction amount for Widow filer types.

Also, you might need to pull from this PR because I cheated and added a small commit directly to your PR from GitHub. Call me if you have any questions.

rickecon commented 1 year ago

@patrickneyland. I just submitted a PR to your ks_sd_rates branch. Once you review that and merge it in, it will automatically update this PR and all the tests will pass. Thanks.

rickecon commented 1 year ago

@patrickneyland. Thanks for getting this. I am merging now.