search

TheCGO / fiscalsim-us

FiscalSim US is a microsimulation model of the US federal and state tax and benefit system relating to households and individuals.
https://thecgo.github.io/fiscalsim-us/
GNU Affero General Public License v3.0
11 stars 12 forks source link

Changing filing status mapping to fix errors #57

Closed austinperryfrancis closed 11 months ago

austinperryfrancis commented 1 year ago

Hey Rick, I've adjusted all of the filing status mapping as discussed.

rickecon commented 1 year ago

@austinperryfrancis. While I am reviewing this, I need you to do two things.

  1. Format your code. This will make the "Check code formatting" GH Action CI test pass.
    • Navigate to your fiscalsim-us repo, and make sure you are in your va_fix branch
    • activate the fiscalsim-us-dev conda environment
    • Type make format
    • Update any changes. Type git status. If the previous format command updated any of your code, push those changes to your branch by doing git add -A, git commit -m "Black formatted code", and git push origin va_fix.
  2. Update the version. This will make your PR automatically update the package that people can download from PyPI.org.
    • Update the version number in line 10 of setup.py to 0.1.6.
    • Add a description of your PR to CHANGELOG.md and changelog.yaml
rickecon commented 1 year ago

@austinperryfrancis. I just submitted a PR to your branch that takes care of my requests (1) and (2) from my last comment. Once you review and approve that PR to your branch, you can merge it and it will automatically get incorporated into this PR.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (3122208) 98.37% compared to head (2225860) 98.57%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #57 +/- ## ========================================== + Coverage 98.37% 98.57% +0.19% ========================================== Files 1773 1773 Lines 26462 26410 -52 Branches 176 142 -34 ========================================== Hits 26033 26033 + Misses 398 346 -52 Partials 31 31 ``` | [Flag](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/57/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO) | `98.57% <23.72%> (+0.19%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO) | Coverage Δ | | |---|---|---| | [...ariables/gov/states/tax/income/state\_income\_tax.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3RheC9pbmNvbWUvc3RhdGVfaW5jb21lX3RheC5weQ==) | `100.00% <ø> (ø)` | | | [...come/state\_income\_tax\_before\_refundable\_credits.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3RheC9pbmNvbWUvc3RhdGVfaW5jb21lX3RheF9iZWZvcmVfcmVmdW5kYWJsZV9jcmVkaXRzLnB5) | `100.00% <ø> (ø)` | | | [...tates/va/tax/income/va\_additions\_to\_federal\_agi.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3ZhL3RheC9pbmNvbWUvdmFfYWRkaXRpb25zX3RvX2ZlZGVyYWxfYWdpLnB5) | `69.23% <ø> (ø)` | | | [...x/income/va\_disability\_income\_reported\_as\_wages.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3ZhL3RheC9pbmNvbWUvdmFfZGlzYWJpbGl0eV9pbmNvbWVfcmVwb3J0ZWRfYXNfd2FnZXMucHk=) | `100.00% <100.00%> (ø)` | | | [.../tax/income/va\_fixed\_date\_conformity\_additions .py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3ZhL3RheC9pbmNvbWUvdmFfZml4ZWRfZGF0ZV9jb25mb3JtaXR5X2FkZGl0aW9ucyAucHk=) | `100.00% <100.00%> (ø)` | | | [...ax/income/va\_fixed\_date\_conformity\_subtractions.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3ZhL3RheC9pbmNvbWUvdmFfZml4ZWRfZGF0ZV9jb25mb3JtaXR5X3N1YnRyYWN0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | | | [...ax/income/va\_income\_from\_obligations\_fed\_exempt.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3ZhL3RheC9pbmNvbWUvdmFfaW5jb21lX2Zyb21fb2JsaWdhdGlvbnNfZmVkX2V4ZW1wdC5weQ==) | `100.00% <100.00%> (ø)` | | | [.../income/va\_income\_from\_obligations\_state\_exempt.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3ZhL3RheC9pbmNvbWUvdmFfaW5jb21lX2Zyb21fb2JsaWdhdGlvbnNfc3RhdGVfZXhlbXB0LnB5) | `100.00% <100.00%> (ø)` | | | [...es/va/tax/income/va\_subtractions\_to\_federal\_agi.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3ZhL3RheC9pbmNvbWUvdmFfc3VidHJhY3Rpb25zX3RvX2ZlZGVyYWxfYWdpLnB5) | `64.28% <ø> (ø)` | | | [...come/household/household\_refundable\_tax\_credits.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9ob3VzZWhvbGQvaW5jb21lL2hvdXNlaG9sZC9ob3VzZWhvbGRfcmVmdW5kYWJsZV90YXhfY3JlZGl0cy5weQ==) | `76.47% <ø> (ø)` | | | ... and [11 more](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/57?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rickecon commented 11 months ago

@austinperryfrancis. Thanks for this PR. Only test not passing is codecov, which is because of a lack of VA tests. Merging now.