TheCGO / fiscalsim-us

FiscalSim US is a microsimulation model of the US federal and state tax and benefit system relating to households and individuals.
https://thecgo.github.io/fiscalsim-us/
GNU Affero General Public License v3.0
9 stars 12 forks source link

Fix circular tax logic with SALT deduction #61

Closed patneyland closed 9 months ago

patneyland commented 9 months ago

What's changed

The SALT deduction is now calculated using the input variables listed above instead of trying to calculate based on the current year fiscalsim-us simulation.

patneyland commented 9 months ago

A single test is failing. Coming out with an incorrect calculation for the salt deduction. \tests\policy\baseline\gov\irs\integration\us_itemize.yaml needs to be adjusted.

codecov[bot] commented 9 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (c908062) 96.68% compared to head (fea2bdb) 98.37%. Report is 14 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #61 +/- ## ========================================== + Coverage 96.68% 98.37% +1.69% ========================================== Files 1401 1773 +372 Lines 21681 26463 +4782 Branches 201 176 -25 ========================================== + Hits 20962 26034 +5072 + Misses 698 398 -300 - Partials 21 31 +10 ``` | [Flag](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/61/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/61/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO) | `98.37% <ø> (+1.69%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#carryforward-flags-in-the-pull-request-comment) to find out more. [see 585 files with indirect coverage changes](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/61/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rickecon commented 9 months ago

@taxpat. Thanks for this one. Awesome. Merging.