TheCGO / fiscalsim-us

FiscalSim US is a microsimulation model of the US federal and state tax and benefit system relating to households and individuals.
https://thecgo.github.io/fiscalsim-us/
GNU Affero General Public License v3.0
11 stars 12 forks source link

Fixed circularity issues for CO and MO #67

Closed mitchellpound closed 11 months ago

mitchellpound commented 11 months ago

What this fixes and how it's fixed

The main problem was from the state_income_tax variable.

CO fixes:

MO fixes:

For both CO and MO I updated the baseline unit test variables to reflect those used in formula definitions.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (66c48e7) 98.37% compared to head (17e52bc) 98.37%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #67 +/- ## ========================================== - Coverage 98.37% 98.37% -0.01% ========================================== Files 1773 1773 Lines 26463 26462 -1 Branches 176 176 ========================================== - Hits 26034 26033 -1 Misses 398 398 Partials 31 31 ``` | [Flag](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/67/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/67/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO) | `98.37% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO) | Coverage Δ | | |---|---|---| | [...states/co/tax/income/additions/co\_state\_addback.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL2NvL3RheC9pbmNvbWUvYWRkaXRpb25zL2NvX3N0YXRlX2FkZGJhY2sucHk=) | `100.00% <100.00%> (ø)` | | | [...income/taxable\_income/mo\_net\_state\_income\_taxes.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL21vL3RheC9pbmNvbWUvdGF4YWJsZV9pbmNvbWUvbW9fbmV0X3N0YXRlX2luY29tZV90YXhlcy5weQ==) | `100.00% <100.00%> (ø)` | | | [...ariables/gov/states/tax/income/state\_income\_tax.py](https://app.codecov.io/gh/TheCGO/fiscalsim-us/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheCGO#diff-ZmlzY2Fsc2ltX3VzL3ZhcmlhYmxlcy9nb3Yvc3RhdGVzL3RheC9pbmNvbWUvc3RhdGVfaW5jb21lX3RheC5weQ==) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rickecon commented 11 months ago

@mitchellpound. This looks great. I ran all the test locally on my machine as well. Everything passes. I submitted a PR to your branch that updates the version in setup.py and adds new entries to the CHANGELOG.md and changelog.yaml files. Once you merge that into your branch, I'll merge this PR.

mitchellpound commented 11 months ago

@rickecon Thanks! Just merged in your PR with the version and change log stuff.

rickecon commented 11 months ago

@mitchellpound. Thanks Mitch. Looks great. Merging.