Closed mitchellpound closed 11 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
66c48e7
) 98.37% compared to head (17e52bc
) 98.37%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mitchellpound. This looks great. I ran all the test locally on my machine as well. Everything passes. I submitted a PR to your branch that updates the version in setup.py
and adds new entries to the CHANGELOG.md
and changelog.yaml
files. Once you merge that into your branch, I'll merge this PR.
@rickecon Thanks! Just merged in your PR with the version and change log stuff.
@mitchellpound. Thanks Mitch. Looks great. Merging.
make format
andmake documentation
has been run.Bug fix
This is to fix the circularity errors mentioned in issue #64
What this fixes and how it's fixed
The main problem was from the
state_income_tax
variable.CO fixes:
state_income_tax
for variables that reference last year's .MO fixes:
state_income_tax
forprior_year_state_income_tax_paid
to break the circularity.For both CO and MO I updated the baseline unit test variables to reflect those used in formula definitions.