RokeJulianLockhart
commented
1 month ago https://github.com/TheCSMods/mc-better-stats/issues/142#issue-2599605595
@JaredRichardWilliam can confirm too.
Open RokeJulianLockhart opened 1 month ago
RokeJulianLockhart
commented
1 month ago https://github.com/TheCSMods/mc-better-stats/issues/142#issue-2599605595
@JaredRichardWilliam can confirm too.
pokesmells
commented
1 month ago Can confirm I am having this issue as well
TheCSDev
commented
1 month ago Hello!
Sorry for the delayed response, as I usually respond sooner.
Now that 1.21.3 ports are out, I'd like to focus on resolving this issue. First off, thank you so much for such a detailed bug report! Very few people put in the effort to try and describe an issue in that much detail.
Now, I'd like to focus on reproducing the issue on my end, so I can find a way to resolve it. To do this, I need to clear up a few issues;
https://kim.nl.tab.digital/s/QsmpqSeZnwsQ2BY, is inaccessible to me. I assume this could be a mod-pack or some sort of configs, however I am unable to reach them (Something called "NextCloud" tells me the file is not found).Once I manage to recreate the issue on my end, it will hopefully help me get closer to the line of code that caused this issue, after which a patch can be made. ((In the meantime, I suppose it'd be a good idea for me to implement (togglable/configurable) network-related error loggers in my mods, if possible.))
Edit: All edits are typo-corrections.
RokeJulianLockhart
commented
1 month ago Could you please provide information on what "Elemental" is? Apologies for not knowing this already. I tried looking it up, but using the search-term "elemental" is too vague to find meaningful results on Google and other search engines.
Apologies. I meant Essential. Filing bugs at night does things to a brain.
The link you have provided, https://kim.nl.tab.digital/s/QsmpqSeZnwsQ2BY, is inaccessible to me. I assume this could be a mod-pack or some sort of configs, however I am unable to reach them (Something called "NextCloud" tells me the file is not found).
Yeah, that wasn't meant to expire. I didn't upload it, but I'll reupload and provide a permanent URI when @JaredRichardWilliam is available again - it's indeed a modpack, and he created it with prismlauncher-9.0-1.fc40.x86_64.
If you're interested, https://github.com/nextcloud/.github/blob/a7b41dc98d8844b64d9c372c84b4afd68e532f9a/profile/README.md#nextcloud explains that NC is just FOSS filehosting platform software.
The biggest one so far; Minecraft doesn't log network-related errors, so the log file you have provided has no useful information unfortunately (go figure, something Minecraft should log, isn't coded by Mojang to be logged). Now I understand this isn't an issue on your end, but I am still stating this just so it's known.
How do you suggest that I log it? I don't mind filing an issue on MC's Jira to eventually have the work performed in the main client, but they'll probably close it as a suggestion (even if I phrase the absence as a bug). Otherwise, I don't mind trying any of the non-destructive options at this Ask Ubuntu answer revision (like wireshark) or https://superuser.com/revisions/22571/1, but I'm unfamiliar with them.
This network-related error also just so happens to be the main focal point of this issue report, so the best I can do is recreate the issue on my end, given the logs do not have the details I need, and the stack-trace shown on-screen doesn't have enough lines to explain the error's origin.
I'll use debug symbols if you can provide them, but I'm unfamiliar with whether those are necessary for languages like DotNet and Java (considering they use microcode), much less how to install them (considering that gdb's debuginfo shan't install them, and they're not available via any OS's package manager).
TheCSDev
commented
1 month ago Thank you so much for the quick response!
As for
How do you suggest that I log it?
You do not have to do anything regarding the error logging, as I* will be responsible for tracing the error to its origin once I recreate the issue on my end. Actually logging the error would require you to mod the game yourself and program it to do that, which obviously, I do not expect anyone to do (nor should you).
I will now get to reproducing the environment and the issue you have described, after which I'll work on a patch. Hopefully everything goes as planned. Thank you once again, and have a great day!
RokeJulianLockhart
commented
1 month ago https://github.com/TheCSMods/mc-better-stats/issues/142#issuecomment-2437517923
@TheCSDev, I've reuploaded the pack at https://github.com/user-attachments/files/17524982/Redy.s.Pack.Fabric.zip ^1
TheCSDev
commented
1 month ago Hello again!
If you do not mind, I have one more question I'd like to ask.
In the latest versions of the game (I used 1.21), I intentionally recreated a scenario where the client would get disconnected due to a network error (by intentionally cutting the server's internet access). To my surprise, I noticed the game is actually logging the error in my case, and it even shows me a button to click on it and view the logs;
I was wondering if something like this takes place on your end, and if the game is leaving any more traces of the error. For me, the game saved an error log file in the [game folder]/debug directory.
And here's the example error log file I was able to find:
---- Minecraft Network Protocol Error Report ----
// I heard pigeons are more reliable
Time: 2024-10-26 13:48:49
Description: Packet handling error
java.net.SocketException: Connection reset
at java.base/sun.nio.ch.SocketChannelImpl.throwConnectionReset(SocketChannelImpl.java:401)
at java.base/sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:434)
at io.netty.buffer.PooledByteBuf.setBytes(PooledByteBuf.java:254)
at io.netty.buffer.AbstractByteBuf.writeBytes(AbstractByteBuf.java:1132)
at io.netty.channel.socket.nio.NioSocketChannel.doReadBytes(NioSocketChannel.java:357)
at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:151)
at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:788)
at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724)
at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562)
at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
at java.base/java.lang.Thread.run(Thread.java:1583)Now that I have the time to, I will also recreate a modded environment using your mod-pack and using the scenario you have provided, and see if any traces are left by the game in that instance as well.
I have recreated the environment by installing the mod-pack to my client and to a server hosted on a VM. I made attempts to join the server both with and without BSS installed. In both instances, I encountered no issues, even after repeated rejoins.
Note that the modpack you have provided is 1.20.1, so I don't know if that plays a role. Now, I also know you mentioned Essential, however I am unfortunately unable to use it due to not having two purchased Minecraft accounts. Lastly, I will see if it's possible for me to attempt regular LAN sessions using two non-authenticated clients aka ones used in mod development environments (and not onces found in "cracked" launchers).
If nothing works, then this could be some sort of incompatibility with Essential, but I am unfortunately unable to verify or check this. I will also have a deep look at my networking-related code, specifically one dealing with ByteBuf-s, as the error message you have shown does usually originate from mishandling of ByteBuf-s.
What happened?
Errata
I attempted to join a world via LAN and Elemental, hosted on another machine (same hardware, launcher, and mod-pack, but different OS) but it would frequently (yet inconsistently) fail with any of the undermentioned error messages:
Reference Count Error
Quotation
Screenshot
Mere Disconnection Error
Quotation
Screenshot
(Lack of) Duplicates
https://github.com/TheCSMods/mc-better-stats/issues?q=is%3Aissue+is%3Aopen+io.netty.handler.codec.EncoderException returned 0 results at +2024-10-19T10:16:56+01:00.
Steps to reproduce
Environment Configuration
Install the OS:
Windows 11
Via https://www.microsoft.com/en-us/software-download/windows11 (or https://www.microsoft.com/en-us/software-download/windowsinsiderpreviewiso).
Fedora 40
Via https://download.fedoraproject.org/pub/fedora/linux/releases/40/Spins/x86_64/iso/Fedora-KDE-Live-x86_64-40-1.14.iso.
Install Prism Launcher:
Import (and configure) the modifications:
Download
https://kim.nl.tab.digital/s/QsmpqSeZnwsQ2BY.Create an instance:
Select the pack:
Leave these disabled (or disable them):
If you see this, create a new one. You shouldn't see it the first time you do so.
Wait for it to extract and import:
Confirmation
Launch the instance.
Host a world on one machine.
Attempt to join it on the other.
This should consistently work, without any failures.
Better Statistics Screen Installation
Install https://modrinth.com/mod/better-stats/version/3.13.2+fabric-1.21:
Enable it (if not already so):
Confirmation
Launch the instance.
Host a world on one machine.
Attempt to join it on the other.
If the error doesn't reproduce immediately, continue to attempt to rejoin. It should occur consistently frequently.
Relevant log output or crash report
I've attached it at https://gist.github.com/RokeJulianLockhart/d2a7ca0b31f2eb45d8e835112749da86/907e0eff17695c8e056f47c9453b99c3722a1fb5#file-slmgf5-txt-log-L6847. It isn't from after instance closure - instead, it's immediately after the reference count error occurred:
Other installed mods
Operative
Without BS.
Inoperative
With BS installed and enabled.
Code of Conduct