search

TheCSharpAcademy / TCSA.V2

A revamp of The C# Academy using all the power of .NET 8's new Blazor!
5 stars 10 forks source link

Users can change pull request url #392

Closed ukpagrace closed 2 months ago

ukpagrace commented 2 months ago

Modified Code to Allow users to change their pull request Screenshot (50) Screenshot (51) Screenshot (49)

ukpagrace commented 2 months ago

@TheCSharpAcademy Thanks for the detailed review. Noted on the required changes and yes I would on it.

stevietv commented 2 months ago

@ukpagrace thanks for submitting! At the moment I can update the PR but I'll request two changes for better UX.

1 - In the dashboard main page: change the button label to view/edit instead of just view, otherwise it's not intuitive that the PR can be updated from there. Also, it would be good if the icon itself was clickable too. And I'm the card for the project underreview should have a yellow border.

@TheCSharpAcademy I think it should be the pending button that becomes Pending/Edit not the view button? the NavLink should indeed include the SVG for the icon inside it.