TheCacophonyProject / bird-monitor

Android application to regularly record birdsong for analysis
GNU General Public License v3.0
11 stars 9 forks source link

Adding a new group - If there is an error, the group stays in the list #32

Closed timhot closed 5 years ago

timhot commented 5 years ago

When adding a new group, if there is an error adding the group, a message is displayed BUT the group stays in the group list - it shouldn't.

Perhaps the group should not be added to the list until after confirmation is received back from the server.

timhot commented 5 years ago

The sortGroups method calls adapter.notifyDataSetChanged(), but I'm not seeing the group list being updated in the user display - can you check please.

jackodsteel commented 5 years ago

The sortGroups method calls adapter.notifyDataSetChanged(), but I'm not seeing the group list being updated in the user display - can you check please.

You're right, and my bad for not testing thoroughly enough. Fixed up in my next PR :)