search

TheCacophonyProject / bird-monitor

Android application to regularly record birdsong for analysis
GNU General Public License v3.0
11 stars 9 forks source link

Issue #25 request permissions #34

Closed timhot closed 5 years ago

timhot commented 5 years ago

Fixed issue #25;

Note 1: It was not as simple as the code on the Vitals screen, as these permissions needed to be asked from a 'Fragment'. The trick was to get the callbacks that went to the SetWizardActivity and the AdvancedWizardActivity to call the callback method in the Fragments.

Note 2: I was concerned about other permissions such as the following, but these don't seem to be an issue - not sure why - perhaps not deemed high risk>

Also: This branch was started before the 'change_app_name' name branch was merged back into master - but I don't think this is an issue as I merged my update local master into this branch on my local machine first - and GitHub reports 'Able to merge' :-)

timhot commented 5 years ago

@mjs I believe I've now implemented all your suggestions. I'll wait for you to agree before I merge.