TheCacophonyProject / cacophony-web-old

Legacy web interface for cacophony-api
GNU Affero General Public License v3.0
2 stars 3 forks source link

Improve query interface for get recordings page #79

Closed arthurmcgregor closed 6 years ago

arthurmcgregor commented 6 years ago

Significant changes to the get recordings page.

So hopefully that all works and is an improvement.

A few questions (because I don't really know how this is actually used!)

Screenshots Desktop size - before desktop1 Desktop size - after desktop2 Mobile size - before mobile1 Mobile size - after mobile2

mjs commented 6 years ago

This is excellent. Thanks! Answers to your questions:

Are devices and tags the most commonly used query fields, or should something else be at the top of the page?

The device and tags fields are the most common ones.

Do you ever want to filter by (devices || tags) && (duration || date)? Because 'get all' only does (devices || tags) and 'get all from conditions' only does (date || duration). I feel these two could be combined into one 'Search' button or 'Filter' or 'Get recordings'

There should be just one button. I like "Search" as the name for it.

Do you ever want to choose several devices? ie a checklist rather than a drop down list

Not really, but we would like to be able to filter by "device group". We'll have to figure out how to query the API for that.

Ditto for tags

The field called "Tags" should actually be called "Tag type" or "Tag class". The current combinations in the drop down are all we need right now.

At some stage we need to add searching by tag (i.e. animal). That would be nice to do as a series of checkboxes.

See my email too for more UI suggestions. No need to do them all in one PR though. This is a great start.

I'll leave the code review for @CameronRP .

arthurmcgregor commented 6 years ago

Thanks for your email and feedback @mjs. Will look to incorporate those ideas as well...

mjs commented 6 years ago

@arthurmcgregor Did you want to land this and then propose more PRs with some of the other suggestions?

arthurmcgregor commented 6 years ago

@mjs Yup will do :-)

CameronRP commented 6 years ago

@arthurmcgregor Code is now live on the test server :) https://browse-test.cacophony.org.nz/get_recordings

arthurmcgregor commented 6 years ago

Yay! Now I can see how well it works on an actual mobile phone...

Plus summarised all of these ideas in #81

mjs commented 6 years ago

@arthurmcgregor it's already so much better - thank you! Looking forward to seeing what else you come up with.