Closed arthurmcgregor closed 6 years ago
This is excellent. Thanks! Answers to your questions:
Are devices and tags the most commonly used query fields, or should something else be at the top of the page?
The device and tags fields are the most common ones.
Do you ever want to filter by (devices || tags) && (duration || date)? Because 'get all' only does (devices || tags) and 'get all from conditions' only does (date || duration). I feel these two could be combined into one 'Search' button or 'Filter' or 'Get recordings'
There should be just one button. I like "Search" as the name for it.
Do you ever want to choose several devices? ie a checklist rather than a drop down list
Not really, but we would like to be able to filter by "device group". We'll have to figure out how to query the API for that.
Ditto for tags
The field called "Tags" should actually be called "Tag type" or "Tag class". The current combinations in the drop down are all we need right now.
At some stage we need to add searching by tag (i.e. animal). That would be nice to do as a series of checkboxes.
See my email too for more UI suggestions. No need to do them all in one PR though. This is a great start.
I'll leave the code review for @CameronRP .
Thanks for your email and feedback @mjs. Will look to incorporate those ideas as well...
@arthurmcgregor Did you want to land this and then propose more PRs with some of the other suggestions?
@mjs Yup will do :-)
@arthurmcgregor Code is now live on the test server :) https://browse-test.cacophony.org.nz/get_recordings
Yay! Now I can see how well it works on an actual mobile phone...
Plus summarised all of these ideas in #81
@arthurmcgregor it's already so much better - thank you! Looking forward to seeing what else you come up with.
Significant changes to the get recordings page.
So hopefully that all works and is an improvement.
A few questions (because I don't really know how this is actually used!)
Screenshots Desktop size - before Desktop size - after Mobile size - before Mobile size - after