TheCanadianConfederationDebates / TCCD

Repository for the data and codebase for The Canadian Confederation Debates project.
1 stars 6 forks source link

notBefore and notAfter in personography.xml #127

Closed DanielHeidt closed 6 years ago

DanielHeidt commented 6 years ago

Does personography.xml handle notBefore and notAfter tags?

Please consider the following example: `

King, George Gerald
              <affiliation when="1878" n="AB/SK House of Commons" ref="plc:QUEE2">Queen's</affiliation>
              <affiliation when="1891" n="AB/SK House of Commons" ref="plc:QUEE2">Queen's</affiliation>
              <affiliation when="1896" n="AB/SK House of Commons" ref="plc:SUNB2">Sunbury--Queen's</affiliation>
              <affiliation when="1896" n="AB/SK House of Commons" ref="plc:QUEE2">Queen's</affiliation>
           </person>`

In order to know which riding to assign this historical figure's 1896 comments to, I assume I need to define the dates of his tenure as an MP for each riding? If this can be done, may I ask what the syntax for this would be?

martindholmes commented 6 years ago

We don't have any mechanism for assigning anyone's comment to a subset of themselves; they're just attached to the person. Of course the comments themselves have a date, so a reader can probably figure out what role the person was filling at that time.

We could devise an elaborate mechanism using dating attributes and a lot of cunning XSLT, but to be brutally honest there will never be time for me to implement it. No new features is the watchword, otherwise we'll never finish the project at all.

DanielHeidt commented 6 years ago

Agreed. Not looking for new features. I found a workaround in the meantime.