Popups - Githubissues

TheCanadianConfederationDebates / TCCD

Repository for the data and codebase for The Canadian Confederation Debates project.

1 stars 6 forks source link

Popups #85

Closed DanielHeidt closed 6 years ago

DanielHeidt commented 6 years ago

Change around some of the content in the popups (I don't believe any new content has to be generated) to match the attached example.

The example was designed from the map popup, but I think it is readily adaptable to the popups that appear in the debate days.

Once the content displays in the correct order, Frank said he'll take care of any remaining aesthetic issues.

website design popup template.docx

martindholmes commented 6 years ago

In personography, move ParlInfo links into <note> elements.
Process personography listBibl ptrs (which are now all dcb) into a little icon link next to the name.

martindholmes commented 6 years ago

Done.

DanielHeidt commented 6 years ago

@martindholmes changes look great. @FrankFlitton please finish styling according to my suggestions.

DanielHeidt commented 6 years ago

A minor bug report. On a French debate day, the popups display the links to other English documents from the same historical figure. See, for example, this screenshot from David Ressor on http://hcmc.uvic.ca/confederation/fr/lgPCLC_fr_1865-02-13.html.

Fixing this is probably just a matter of adding some additional language sensitivity to the build process that populates these popups?

martindholmes commented 6 years ago

Does look like a bug. However, there's a decision to be made too: if there's no French equivalent to an English-language document, should the English document be included in lieu?

DanielHeidt commented 6 years ago

Thanks for the quick response. If we listed English language texts when the French are unavailable, would it be possible for these entries to have "(en anglais seulement)" listed after — or as part of —the link?

martindholmes commented 6 years ago

Fixed as part of work on another ticket today.