TheCanadianConfederationDebates / TCCD

Repository for the data and codebase for The Canadian Confederation Debates project.
1 stars 6 forks source link

Postal code map functionality #91

Closed DanielHeidt closed 6 years ago

DanielHeidt commented 6 years ago

After zooming in and out of the map, popups appear to be displaying outside of frame and cannot be accessed by users.

Also, please have all links clicked from map popup appear in a new tab. Rationale: if the user clicks "back" the map resets and they lose their spot. By opening a debate day selected from this map interface in a new tab, the user can always go back and select another nearby riding.

martindholmes commented 6 years ago

Could you make this into a proper bug report:

The new-tab thing should be a separate ticket; are there other contexts where you also want to pre-empt the user's control over tabs/windows in the browser, or just in the map?

DanielHeidt commented 6 years ago

Sure. The issue appears to related to scrolling on the page after the popup has been called.

Here is the info you requested:

  1. go to http://hcmc.uvic.ca/confederation/en/index.html
  2. Zoom in on a random riding and click it
  3. The popup appears half outside of the page (see first screenshot) 1
  4. Scroll down the page to view other parts of the website without clicking any links
  5. then scroll back up to the map and view the popup—which now appears further up the page (see second screenshot). 2
martindholmes commented 6 years ago

Nothing appears outside the page; the popups appear above the map, and always in the same place. (If they're bigger, they take up more screen space, of course.) Where exactly would you like them to appear?

DanielHeidt commented 6 years ago

@FrankFlitton - modify header so that it stays same height. Currently on mobile size the header goes into a single column. Instead, please have the header switch to a three bar button that can be clicked to expand the menu.

martindholmes commented 6 years ago

I've just tested this on two versions of OSX and I can't reproduce it. Either Chrome fixed a bug, or an update to OpenLayers solved it.