Make script compatible with Aphrodite and Phantom branches

TheCaptain989 / radarr-striptracks

A Docker Mod to Radarr/Sonarr to automatically strip out unwanted audio and subtitle tracks

https://hub.docker.com/r/thecaptain989/radarr-striptracks

GNU General Public License v3.0

20 stars 1 forks source link

Make script compatible with Aphrodite and Phantom branches #29

Closed foXaCe closed 3 years ago

foXaCe commented 3 years ago

hello it possible to support aphrodite branch ?

TheCaptain989 commented 3 years ago

Sorry, I somehow missed this. Let me check on your request and I'll get back to you.

TheCaptain989 commented 3 years ago

Okay, I'm working on this now. It shouldn't be too bad at all. I'll need to support Sonarr v3 also due to my combined script-base, modify build hooks, create wrapper scripts, etc. Starting work now.

foXaCe commented 3 years ago

ok thanks you

foXaCe commented 3 years ago

the script orders streams video first ,audio and subtitles ?

foXaCe commented 3 years ago

hello

where is the striptracks-fra.sh file ?

foXaCe commented 3 years ago

TheCaptain989 commented 3 years ago

I'm still testing! I have only test-built a Sonarr container, not even a Radarr one yet. I'll post back here once everything is ready.

foXaCe commented 3 years ago

I can help you if needed

foXaCe commented 3 years ago

for test the french script

TheCaptain989 commented 3 years ago

Thank you. Okay, I think I've got it. Try the preview branch/tag and let me know. There were script changes I had to make in addition to the wrapper scripts. Lots of testing needed, which I did under Sonarr. I did minimal testing under Radarr so far.

foXaCe commented 3 years ago

the script works great with sonarr. I will do some tests with radarr. why use an old version of mkvmerge ?

TheCaptain989 commented 3 years ago

the script works great with sonarr.

Excellent.

I will do some tests with radarr. why use an old version of mkvmerge ?

It wasn't on purpose. I don't know why all previous builds were pulling v19 of mkvmerge or why the latest radarr build pulled v45. I want to use the newer versions, but it will take a rewrite of the core of the script. I created bug report #37 to track this.

foXaCe commented 3 years ago

hello,

with radarr I have this bug [412]Error|Unable to locate or invalid remuxed file:

my file has french accents like this d'Écosse

foXaCe commented 3 years ago

same error with movie title no accents

[499]Error|Unable to locate or invalid remuxed file:"/media/*****-1080p.mkv". Undoing rename.

TheCaptain989 commented 3 years ago

Yeah, these are symptoms of the wrong version of mkvmerge. The striptracks.txt log should have an mkvmerge usage dump also.

Unfortunately, I won't be able to get to this until next weekend. Sorry about the trouble.

TheCaptain989 commented 3 years ago

I won't be able to get to this until the 3rd at the soonest.

foXaCe commented 3 years ago

Ok. No problem.

TheCaptain989 commented 3 years ago

I hacked my way around things sooner than I thought. I just pushed new builds for Sonarr and Radarr preview branches with my new script. It should work with all versions of mkvmerge also.

foXaCe commented 3 years ago

Great. I will do some testing and I will get back to you. why are the sonarr and radarr versions not up to date?

foXaCe commented 3 years ago

ok is up to date now

foXaCe commented 3 years ago

ok all work great. very good job. only sonarr have old version of mkvmerge. thanks for all man.

TheCaptain989 commented 3 years ago

No problem. I'm not specifying the mkvtoolnix version in the build at all, so I would assume it would get the latest. No idea why Sonarr pulls the older version, but at least the script will work with both versions! Please do let me know if you run into anything else. If you do, please enable debugging and attach your log snippet.