TheCheatsrichter / Gw2_Launchbuddy

Custom launcher generator for the video game Guild Wars 2.
MIT License
201 stars 44 forks source link

TacO cannot find GW2MumbleLink #202

Closed FelixGerberding closed 3 years ago

FelixGerberding commented 3 years ago

Hey guys,

I've been encountering some issues with TacO and LB recently. Not sure whether or not this is your part of the code or an issue related to TacO but since you're working on it together I'll just dump what I found here.

So when I start a single client using Launchbuddy and afterward start TacO using the button in Launchbuddy, everything works fine. However, if I try to do the same with multiple clients running, it works sometimes. I'm currently still trying to find a way to reliably reproduce this problem and keep you update If I find it.

TacO states the following problem in the log: Closing TacO because GW2 with mumble link GW2MumbleLink2 was not found in under a minute The number (in this case 2) changes according to the account I tried to start it on.

I'm currently using d912pxy as well as ReShade and did not encounter any other problems with this setup. Everything is updated to the most recent version, running with admin permissions and in windowed fullscreen. Versions can be found below:

Software Version
d912pxy 2.3.0
ReShade 4.8.2
LaunchBuddy 2.2.1
TacO 47.2802r
Game 109065

Looks like someone had a similar problem here.

That's what I gathered so far. If you require any additional details regarding my setup or any logs, feel free to reach out.

Best regards Felix

Edit: Table was broke

FelixGerberding commented 3 years ago

After inspection using ProcessExplorer I found out that the -mumble parameter is not set. If I'm not wrong this line should be responsible for adding it.

How exactly does ClientManager.ActiveClients.Count work? It is working if I have 2 clients running and start another one, but It does not work if I start all 3 together.

FelixGerberding commented 3 years ago

Reverting back to 2.2 resolves this. Seems to be a problem with the line mentioned above.

ScrambledBrain commented 3 years ago

Hi,

https://github.com/TheCheatsrichter/Gw2_Launchbuddy/releases/tag/2.2.1 states:

For this reason LB starts all first selected GW2 accounts without a mumble link ! Only if already at least one GW2 client is running and another GW2 account is started later in LB, they will get started with a mumble link.

The issue is now: TacO starts with the mumble link, if multiple GW2 accounts are loaded, resulting in TacO times out for all 1st started GW2 accounts without GW2 mumble links and works for the later started GW2 accounts.

Current workaround for LB 2.2.1: Start 1st GW2 account => then start matching TacO => TacO starts now without mumble link -> works Start 2nd GW2 account(s) => then start matching TacO => TacO starts now with mumble link -> works

Alternatively go back to LB 2.2.0, which is more comfortable at the moment ;D

=> I think, it would be an idea to make an option available to de-/activate mumble links at all or separated for each account to make the behaviour more clear enough.

TheCheatsrichter commented 3 years ago

This issue should be resolved with https://github.com/TheCheatsrichter/Gw2_Launchbuddy/commit/ed2914ae66a3957fe5921b4620dde1733f752d27 Tested it on my machine and seems to work. First acc now gets the correct Mumble Link.

ScrambledBrain commented 3 years ago

This issue should be resolved with ed2914a Tested it on my machine and seems to work. First acc now gets the correct Mumble Link.

Thanks TheCheatsrichter. At first I was confused, because no account started with a mumble link but then I found the option in "Account settings > {account} > Advanced Settings: Use Custom Mumble Link" and this worked like a charm now.