search

TheCherno / Hazel

Hazel Engine
Apache License 2.0
11.61k stars 1.5k forks source link

Setup.bat crashes without Python installed; Getting Started section of README does not mention Python dependency #534

Open cugone opened 2 years ago

cugone commented 2 years ago

Description

There is no mention of Python being a required dependency in order to run setup.bat in the README Getting Started instructions

Repro steps

Steps to reproduce the behavior:

  1. Clone the repo recursively.
  2. Run Setup.bat
  3. Select Y at the prompt to install the 'requests' Python package.
  4. Observe script crashes because 'pip' is not installed.

Expected behavior

A successful installation of Hazel without dependency of Python

Operating system:

GamerHammer2K4F647Ultimate commented 2 years ago

I mean, how would you get the required stuff without Python. With Python, you don't have to install more than 2 programs(maybe a bit more). But yeah, it should be in the README file.

On2 5 Jan 2022, at 21:40, cugone @.***> wrote:

Description

There is no mention of Python being a required dependency in order to run setup.bat in the README Getting Started instructions

Repro steps

Steps to reproduce the behavior:

Clone the repo recursively. Run Setup.bat Select Y at the prompt to install the 'requests' Python package. Observe script crashes because 'pip' is not installed. Expected behavior

A successful installation of Hazel without dependency of Python

Operating system:

OS: Windows 64-bit Version: Windows 10 Home Other: Python not installed. — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you are subscribed to this thread.

cugone commented 2 years ago

I mean, how would you get the required stuff without Python....

Custom C++ cURL/libcurl and zlib code. All the Python scripts do is download and unzip files from the internet. (Hence the requests package.)

LovelySanta commented 2 years ago

I would opt for using PyInstaller to genereate an exe out of the python script, thus removing the requirement for someone to install python at all, as PyInstaller will setup a temporary environment (with all the required python dependencies) prior to executing the python code.