Mat4 columns

[mahlerni]

Shouldn't this

vec4 getColumn(int index)
        {
            index *= 4;
            return vec4(elements[index], elements[index + 1], elements[index + 2], elements[index + 3]);
        }

be this instead?

vec4 getColumn(int index)
        {
            return columns[index];
        }

(mat4.h)

[Maxchii]

What you are suggesting would return an element not a column.

Actually you may be right! I forgot about Vector4 columns[4]; in Mat4.h

[TheCherno]

@mahlerni It totally should, I wrote that code to demonstrate how not to do it. Really the method shouldn't even exist, since columns is public. It could be kept the way you rewrote it, but returning a reference.