TheCherno / Sparky

Cross-Platform High Performance 2D/3D game engine for people like me who like to write code.
Apache License 2.0
1.1k stars 223 forks source link

Multiple build fails #72

Closed RomanTruhanov closed 8 years ago

RomanTruhanov commented 8 years ago

poc

TheCherno commented 8 years ago

Hmm, which projects are causing these errors? My suspicion is that it's the SparkyCLI and SandboxCS projects, judging by those include errors, which is expected. Unload those projects and see if that fixes it.

DontBelieveMe commented 8 years ago

I found this when trying to build sparky. To sort them the post build events in sparky-core had to be removed and the fbx-sdk had to be added to the Dependencies folder and the SparkyCS and SparkyCLI projects had to unloaded.

RomanTruhanov commented 8 years ago

yes, I'am add depend fbx sdk to SPMBuild it's simply fixed and fix core post build event change

xcopy /f /y $(SolutionDir)Dependencies\FreeImage\bin\FreeImage.dll $(SolutionDir)bin\$(Configuration)\* to xcopy /f /y "$(SolutionDir)Dependencies\FreeImage\bin\FreeImage.dll" "$(SolutionDir)bin\$(Configuration)\"

and

xcopy /f /y $(SolutionDir)Dependencies\OpenAL\bin\x86\OpenAL32.dll $(SolutionDir)bin\$(Configuration)\* to xcopy /f /y "$(SolutionDir)Dependencies\OpenAL\bin\x86\OpenAL32.dll" "$(SolutionDir)bin\$(Configuration)\"

all other project build ok only SparkyCS and SparkyCLI contain errors

Ilohama commented 8 years ago

you don't have to add the fbx sdk, it's only usefull for SPMBuild which is already build build in his release version. Moreover, you don't have to change the xcopy O_o

DontBelieveMe commented 8 years ago

I pulled the code directly from github, so maybe that's why it didn't work straight away.

Ilohama commented 8 years ago

I pulled it from github too but i don't have a lots of problems. Just unload sparkyCLI, sandboxCS and SPMBuild and it works. You don't have to change the xcopy if you're not too deep in subfolders (C:\Sparky works really great).

RomanTruhanov commented 8 years ago

it's just list all error clean build after git clone in this repo, and simple fixes some errors which I know what to do...

Ilohama commented 8 years ago

As i saw, common error with xcopy is the path length is too long, so avoid a deep subfolder location. The Sparky-CLI and then SandboxCS isn't working too after that API changes. And if libfbxsdk-md.lib isn't found, it's the fault of the size of the lib (i think it's over 100Mb, so Github don't want of it) but the fbx sdk is usefull only for the SPMBuild project that have his release in a folder so you don't really have to rebuild it, that's why i say to unload it :D

RomanTruhanov commented 8 years ago

xcopy error

this errors be in my experience and this solution how I make it solves this problem maybe it better I don't known

DontBelieveMe commented 8 years ago

The xcopy isnt needed anyway is it? I removed it and all the projects seem to be building and running fine.

Ilohama commented 8 years ago

xcopy is needed to run the sandbox. everytime you change the sparky core, if you don't xcopy the sparky core, the sandbox won't be updated on the core. Xcopy is here to be sure that you have all the dlls and all other stuff in the correct folder for compilling and executing

RomanTruhanov commented 8 years ago

I fixed normally, xcopy scripts (it's need to correct run program just not copy manual library in program dir not serious error) but SparkyCS and SparkyCLI broken build I don't want use c# but its error and need fixed...

michalkelnar commented 8 years ago

This change xcopy /f /y $(SolutionDir)Dependencies\FreeImage\bin\FreeImage.dll $(SolutionDir)bin\$(Configuration)* to xcopy /f /y "$(SolutionDir)Dependencies\FreeImage\bin\FreeImage.dll" "$(SolutionDir)bin\$(Configuration)\"

and

xcopy /f /y $(SolutionDir)Dependencies\OpenAL\bin\x86\OpenAL32.dll $(SolutionDir)bin\$(Configuration)* to xcopy /f /y "$(SolutionDir)Dependencies\OpenAL\bin\x86\OpenAL32.dll" "$(SolutionDir)bin\$(Configuration)\" that Roman mentioned is necessary for people how saved project in path with spaces. Like he did ..\Visual studio 2015..

Ilohama commented 8 years ago

SandboxCS CAN'T work without the SparkyCLI, and as i said, after the API review and some other stuff, the SparkyCLI have to be recoded so that's why for now it have to be unload. @michalkelnar : Owww yeah you're right!

RomanTruhanov commented 8 years ago

i know it's at once when he opened topic i want know how so many need recode... unload projects to simple and not ideal solution this problem

TheCherno commented 8 years ago

Those projects are currently WIP, which is why they don't compile. You don't have to unload them, you'll still be able to compile/run Sandbox (and tools) just fine without them. Unloading them just gets rid of the error messages (amongst other things).