search

TheCherno / Sparky

Cross-Platform High Performance 2D/3D game engine for people like me who like to write code.
Apache License 2.0
1.1k stars 223 forks source link

Implemented Better Logging In The Win32Log.cpp #99

Closed ghost closed 8 years ago

ghost commented 8 years ago

I added some override methods for the sparky platform log. Added a log to file method to it as well.

PastaPastaPasta commented 8 years ago

Sparky-core/src/sp/platform/windows/Win32Log.cpp - line 65 a space or other seperator should be added after filename.

ghost commented 8 years ago

i don't think it's a good idea to use C headers

jannisj1 commented 8 years ago

i don't think it's a good idea to use C headers

Give reasoning please. Otherwise it's no constructive criticism.

ghost commented 8 years ago

I heard that its rather bad to use them because they are kind of deprecated and so on. And it is always better to write modern c++11 code i guess :P My comment wasnt meant as critic and that its bad practice it was more of a tip. Please correct me if i am wrong but i dont want to start a discussion about that stuff on here ^^

jannisj1 commented 8 years ago

@unpause didn't want to start a discussion too, but I think it's better to just give your reasoning with an opinion rather than waiting for somebody to ask for it :) But back to the point: There is nothing wrong with including c-headers, in fact the c++ standard library includes the c headers at some point anyways (atleast in msvc++). Using the actual c functions alot is debatable thats true.