search

TheChymera / mkstage4

Bash Utility for Creating Stage 4 Tarballs
GNU General Public License v3.0
104 stars 22 forks source link

Try to compress parallelly #15

Closed liu-kan closed 5 years ago

liu-kan commented 5 years ago

Archive will be compressed parallelly, if pbzip2 is installed.

TheChymera commented 5 years ago

Thank you for the contribution! I am not familiar with pbzip2.

  1. Can its archives be extracted with the normal single-threaded support built-in in tar?
  2. At any rate I'm quite skeptical about deciding what to do based only on what executables can be found at runtime. I think it would be best to include a flag so that users can select whatever tool they want even if they have both available (i.e. an option which allows running mkstage4 with the traditional tar, even if bzip2 is available).
liu-kan commented 5 years ago
  1. Yes, it can be extracted with the normal single-threaded support built-in in tar.
  2. I add -k flag, and remove the code about auto detect pbzip2.
TheChymera commented 5 years ago

@liu-kan Great! Can you update the readme to reflect the updated functionality in the PR --- and rebase this into a single commit?

liu-kan commented 5 years ago

Done.

TheChymera commented 5 years ago

Thank you!