search

TheChymera / mkstage4

Bash Utility for Creating Stage 4 Tarballs
GNU General Public License v3.0
104 stars 22 forks source link

Loop through excludes #21

Open drwulsen opened 5 years ago

drwulsen commented 5 years ago

Here it is, as promised - the loop-generated excludes list in a separate PR. Let me know what you think of it.

TheChymera commented 4 years ago

@drwulsen sorry for the late reply. Looks good to me. Have you had the opportunity to test it?

Also, could you rebase this into one commit?

drwulsen commented 4 years ago

I've figured that I'm too stupid for github and all the branches, PRs, commits and stuff. The script still has some issues to work on; for example it creates the kmod and ksrc archives with weird and non-readable content.

I've fixed this and edited a lot of the script in my fork of it, but how to get five things back into one file where one change depends on the other....well, I think I'll be outta here and you are welcome to use whatever you find useful from my fork - but maintaining any form of consistency seems quite un-possible to me with my github knowledge.....

TheChymera commented 4 years ago

@drwulsen I know how you feel, git rebase has the bad habit of being quite frustrating and blowing up in the faces of people who are not gurus :D

A nice thing about github is that you can just take a PR (e.g. this one), write .patch after the link, and you get a patch for all changes. You can just fork this repo again, apply the patch and re-submit the PR. I'd prefer this came from you so that you're properly listed as the author.