TheChymera / mkstage4

Bash Utility for Creating Stage 4 Tarballs
GNU General Public License v3.0
104 stars 22 forks source link

Bug fix for when no tar options are passed #24

Closed Tatsh closed 4 years ago

Tatsh commented 4 years ago

My last PR introduced a bug when no tar options are given because in that scenario the argument would be '' which tar does not just ignore.

tar: Substituting `.' for empty member name

Also:

Tatsh commented 4 years ago

Also, since profile 17.1, all systems should have kernel modules under /lib/modules. This removes the need for checking x86-64.

To maintain backward compatibility, you can archive "${TARGET}lib"*"/modules/$(uname -r)"*. I can provide this fix in this branch too if you would like.

TheChymera commented 4 years ago

Yes, backwards-compatibility would be nice, with Gentoo being rolling-release it's likely we'll have users with older profiles for a very long while.

Thanks for sniffing out those errant tabs.

For identity checks I would prefer to keep all strings quoted. You never know what weird variable names people have defined in their session.

Tatsh commented 4 years ago

Will fix the strings shortly

Tatsh commented 4 years ago

All set

TheChymera commented 4 years ago

Could you rebase the commits into one?

Tatsh commented 4 years ago

Done

TheChymera commented 4 years ago

Thank you!