search

TheChymera / mkstage4

Bash Utility for Creating Stage 4 Tarballs
GNU General Public License v3.0
104 stars 22 forks source link

The default file extention for Zstd is .zst not .zstd #41

Closed tremd closed 3 years ago

tremd commented 3 years ago

Only a minor issue but if i use zstd compression mode with -C zstd the output stage4 has the wrong file extension. zstd instead of zst

TheChymera commented 3 years ago

@tremd thanks for reporting :)

Can you check whether https://github.com/TheChymera/mkstage4/commit/351c9fe682f60bd4225d45d77e04c3a7e09ad072 fixes this?

RinCat commented 3 years ago

Zstd command is /usr/bin/zstd, but extension is zst. Current version not works.

TheChymera commented 3 years ago

@RinCat thanks for the feedback. By current version do you mean HEAD, or the release? The latest release as of right now won't be working in any case, since it predates this fix. But I think you have a point, and I messed up the fix in HEAD. Can you try now after 783e7ea52a500162efe59c154d7e4fe71a93cfac ? :)

RinCat commented 3 years ago

I mean the HEAD, since I downloaded raw. I guess it is OK to use zst instead of zstd for the format name. The new version works if I set -C zst.

TheChymera commented 3 years ago

@RinCat amazing! ^^